Repository navigation
Rank promotion feedback - #505
Open
JoyfulShush wants to merge 5 commits into
Open
JoyfulShush wants to merge 5 commits into
JoyfulShush wants to merge 5 commits into
Conversation
|
Development builds of 64ed31b:
The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
ZivDero
requested changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451
Refactors the VeterancyClass somewhat. It now accepts a callback for reporting promotions.
The only way to change the amount of experience a techno has is through
Set_Experience, which is used as a pipeline to changing the experience and checking if the callback should be called, producing a promotion event. It can never go overVeteranCap.Requests to change the experience now pass whether those experience changed should be notified to the player by the caller via sounds and flashes (assuming those are defined in
Rules.ini), giving callers control over those announcements. For example, an Armory or a promotion crate would announce the unit being promoted, but pre-placed units or units spawned by a trigger as promoted will not.