Repository navigation
chore(db): default DB_SERVER_VERSION to 8.4.11 - #659
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update server version defaults .env.example, config/database.php |
The sample environment value and the model read, model write, and standard connection defaults change to 8.4.11. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested reviewers: romanetar
Merge Risk: 
Minimal · up to 48b9e
-
The version defaults are consistently updated across the database configuration and sample environment.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-659/ This page is automatically updated on each push to this PR. |
ref: https://app.clickup.com/t/9014802374/86bc4fj9g
Summary
Prod and staging MySQL now run 8.4.11, but the default
DB_SERVER_VERSIONinconfig/database.php(all three connections) and.env.examplewas still8.0.43. Doctrine uses this value to choose its SQL platform instead of detecting it, so it kept treating the server as 8.0.With DBAL 3.9.4 (the version in
composer.lock),8.4.11selectsMySQL84Platforminstead ofMySQL80Platform. That platform is a small extension of the 8.0 one (mainly the 8.4 reserved-keyword list); the generated SQL for existing queries does not change.Related: CI/local MySQL 8.4 bump in summit-api #651.
Deployment steps
argocd-appssetsDB_SERVER_VERSION, so prod and staging pick up the new default on the next deploy.Tests
php -l config/database.phpis clean. CI runs the suite against MySQL 8.4.