Skip to content

chore(db): default DB_SERVER_VERSION to 8.4.11 - #659

Merged
smarcet merged 1 commit into
mainfrom
chore/db-server-version-8.4
Oct 29, 2026
Merged

smarcet merged 1 commit into
mainfrom
chore/db-server-version-8.4

Conversation

@smarcet

@smarcet smarcet commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

ref: https://app.clickup.com/t/9014802374/86bc4fj9g

Summary

Prod and staging MySQL now run 8.4.11, but the default DB_SERVER_VERSION in config/database.php (all three connections) and .env.example was still 8.0.43. Doctrine uses this value to choose its SQL platform instead of detecting it, so it kept treating the server as 8.0.

With DBAL 3.9.4 (the version in composer.lock), 8.4.11 selects MySQL84Platform instead of MySQL80Platform. That platform is a small extension of the 8.0 one (mainly the 8.4 reserved-keyword list); the generated SQL for existing queries does not change.

Related: CI/local MySQL 8.4 bump in summit-api #651.

Deployment steps

  • None required. No environment in argocd-apps sets DB_SERVER_VERSION, so prod and staging pick up the new default on the next deploy.

Tests

php -l config/database.php is clean. CI runs the suite against MySQL 8.4.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2f463f2b-0bb5-45bb-86d1-22e5fdd6ed4d
Commits

Reviewing files that changed from the base of the PR and between 0eac852 and 48b9e8c.

Files selected for processing: 2
  • .env.example
  • config/database.php

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The sample environment value and default server versions for the model read, model write, and standard database connections change from 8.0.43 to 8.4.11. Each configuration remains adjustable through DB_SERVER_VERSION.

Changes: Database version defaults

Layer / File(s) Summary
Update server version defaults
.env.example, config/database.php
The sample environment value and the model read, model write, and standard connection defaults change to 8.4.11.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: romanetar

Merge Risk: Minimal · up to 48b9e

The version defaults are consistently updated across the database configuration and sample environment.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the default DB_SERVER_VERSION to 8.4.11.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-659/

This page is automatically updated on each push to this PR.

@smarcet
smarcet merged commit 2981548 into main Oct 29, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant