Skip to content

fix(mysql): make stats and promo code queries compatible with ONLY_FULL_GROUP_BY #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanetar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mysql): make stats and promo code queries compatible with ONLY_FULL_GROUP_BY #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/Models/Foundation/Summit/SummitRegistrationStats.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ public function getAttendeesCheckinsGroupedBy
}
// group by
$sql .= " GROUP BY DATE_FORMAT(CONVERT_TZ(SummitAttendee.SummitHallCheckedInDate,'+00:00','{$offset}'), '{$date_format}')";
$sql .= " ORDER BY SummitAttendee.SummitHallCheckedInDate ASC";
$sql .= " ORDER BY MIN(SummitAttendee.SummitHallCheckedInDate) ASC";

$count_sql = <<<SQL
SELECT COUNT(*) FROM ({$sql}) T1
Expand Down Expand Up @@ -831,7 +831,7 @@ public function getPurchasedTicketsGroupedBy
}
// group by
$sql .= " GROUP BY DATE_FORMAT(CONVERT_TZ(SummitAttendeeTicket.TicketBoughtDate,'+00:00','{$offset}'), '{$date_format}')";
$sql .= " ORDER BY SummitAttendeeTicket.TicketBoughtDate ASC";
$sql .= " ORDER BY MIN(SummitAttendeeTicket.TicketBoughtDate) ASC";

$count_sql = <<<SQL
SELECT COUNT(*) FROM ({$sql}) T1
Expand Down
8 changes: 4 additions & 4 deletions app/Repositories/Summit/DoctrineSummitRegistrationPromoCodeRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,13 +491,13 @@ public function getIdsBySummit
ELSE pc.redeemed
END AS REDEEMED_ORDER,
CASE
WHEN pc.ClassName = 'SponsorSummitRegistrationPromoCode' THEN sp1stt.Name
WHEN pc.ClassName = 'SponsorSummitRegistrationDiscountCode' THEN sp2stt.Name
WHEN pc.ClassName = 'SponsorSummitRegistrationPromoCode' THEN ANY_VALUE(sp1stt.Name)
WHEN pc.ClassName = 'SponsorSummitRegistrationDiscountCode' THEN ANY_VALUE(sp2stt.Name)
ELSE NULL
END AS TIER_NAME_ORDER,
CASE
WHEN pc.ClassName = 'SponsorSummitRegistrationPromoCode' THEN spn1.Name
WHEN pc.ClassName = 'SponsorSummitRegistrationDiscountCode' THEN spn2.Name
WHEN pc.ClassName = 'SponsorSummitRegistrationPromoCode' THEN ANY_VALUE(spn1.Name)
WHEN pc.ClassName = 'SponsorSummitRegistrationDiscountCode' THEN ANY_VALUE(spn2.Name)
ELSE NULL
END AS SPONSOR_COMPANY_NAME_ORDER,
CASE
Expand Down
Loading