Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
There was a problem hiding this comment.
🟡 Changes recommended
In-cell controls can still unintentionally trigger row editing, and removing the Edit button leaves no named edit control discoverable by assistive-technology users.
2 open issues
What changed in this PR
Standardizes Delete actions across the MUI table components and replaces MuiTable’s Edit column with row-click and Enter-key editing.
Changes:
- Moves Delete into a leading row-actions menu with shared labels, destructive styling, and disabled-state support.
- Removes responsive action collapsing while retaining existing Edit buttons in other table variants.
- Updates tests for menu-based deletion and row-edit interactions.
| File | Description |
|---|---|
src/i18n/en.json |
Adds the “More actions” label. |
src/components/mui/tables/sortable-table/index.js |
Moves Delete into a leading menu. |
src/components/mui/tables/sortable-table-v2/mui-table-sortable-v2.js |
Adopts the shared Delete menu. |
src/components/mui/tables/mui-table/index.js |
Adds row editing and reorganizes action columns. |
src/components/mui/tables/editable-table/index.js |
Moves Delete into the shared menu. |
src/components/mui/tables/components/table-styles.js |
Removes action-collapse breakpoint utilities. |
src/components/mui/tables/components/row-actions-menu.js |
Adds shared Delete configuration and menu styling. |
src/components/mui/BulkEditTable/components/Row.js |
Separates Delete from Edit and removes row hover. |
src/components/mui/BulkEditTable/BulkEditTable.js |
Updates headers and removes responsive action props. |
src/components/mui/BulkEditTable/__tests__/BulkEditTable.test.js |
Tests menu deletion with a custom row identifier. |
src/components/mui/__tests__/mui-table.test.js |
Tests row editing, disabled rows, and interaction guards. |
src/components/mui/__tests__/mui-table-sortable.test.js |
Updates deletion tests for the menu. |
src/components/mui/__tests__/mui-table-sortable-v2.test.js |
Updates menu deletion and custom-identifier tests. |
src/components/mui/__tests__/mui-table-editable.test.js |
Updates deletion tests and forwards the mocked button ref. |
Review effort: Balanced
| onEdit && !(options.disableProp && row[options.disableProp]) | ||
| ? { | ||
| hover: true, | ||
| tabIndex: 0, |
| // ignore clicks from popups (menus, dialogs) opened by a cell | ||
| if (!ev.currentTarget.contains(ev.target)) return; | ||
| // ignore clicks on controls rendered inside cells | ||
| if (!ev.target.closest("button, a, input, [role=button]")) onEdit(row); |
…better keyboard user experience
ako3131
force-pushed
the
refactor/move-table-action-buttons
branch
from
October 29, 2026 20:29
80c3816 to
83e8b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bc67fpv
Summary
Declutters MUI table rows: Delete moves into a "⋮" row actions menu, and
MuiTablerows open for editing on click.onEdit; rows disabled viadisablePropstay inert. Clicks on buttons, links, inputs and popups opened from a cell are ignored. Delete is in a new first column menu, disabled on disabled rows. Archive / View are unchanged.aria-label("More actions"), red styling for destructive items, trigger disabled when every action is disabled. New sharedgetDeleteAction()helper.options.responsive,getActionsMenuBreakpoint).hover; hover now only marks clickable rows.Breaking changes
MuiTablehas no Edit column. Extra rows passed aschildren(e.g.TotalRowcolGap/trailing) need updating.action-edit/action-deleteare gone; userow-actions-menu-trigger+ the "Delete" menu item.options.responsiveno longer has any effect.summit-admin follow-up needed:
sponsor-cart-tab/components/cart-view.js(TotalRow layout, test ids).Testing
yarn testandyarn buildpass.