Skip to content

Reports: a value masked by hand is no identifier #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openipc-ai merged 1 commit into from
Oct 30, 2026
Merged

Reports: a value masked by hand is no identifier #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion service/internal/reports/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ func textIdentifiers(text string) []Identifier {
var out []Identifier
seen := map[string]int{}
add := func(name, v string) {
if (name == "cloud_id" && !strings.ContainsAny(v, "0123456789")) || zeroish(v) {
if (name == "cloud_id" && !strings.ContainsAny(v, "0123456789")) || !alnum.MatchString(v) || zeroish(v) {
Comment thread
openipc-ai marked this conversation as resolved.
Resolved
return
}
k := strings.ToLower(v)
Expand Down Expand Up @@ -453,6 +453,11 @@ func textIdentifiers(text string) []Identifier {
return out
}

// alnum: a value with a letter or a digit in it. One a sender masked by hand
// ("CloudCryNum" : "#######") is no identifier, and replacing it would take
// every run of #s in the log with it (r-7tb674nu).
var alnum = regexp.MustCompile(`[A-Za-z0-9]`)

func countFold(text, v string) int {
return strings.Count(strings.ToLower(text), strings.ToLower(v))
}
Expand Down
10 changes: 10 additions & 0 deletions service/internal/reports/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,3 +290,13 @@ func TestIpctoolsShortCloudIDAndTheLogsSerialAreOne(t *testing.T) {
t.Errorf("redacted:\n%s", got)
}
}

// A value its sender masked by hand is no identifier: the #s it was masked
// with stay, and so do the log's other runs of them.
func TestAValueMaskedByHandIsLeftAlone(t *testing.T) {
log := `{ "CloudCryNum" : "#######", "DevInfo" : { "Data" : "*********", "Key" : "31415926" } }` + "\n####### boot #######\n"
got := Redact(log, Facts{}, "k")
if strings.Count(got, "#######") != 3 || !strings.Contains(got, `"*********"`) || strings.Contains(got, "31415926") {
t.Errorf("redacted:\n%s", got)
}
}
Loading