Skip to content

SPI NOR: the bits of SR3_DRV0 and SR3_DRV1 - #55

Merged
compot-dev merged 1 commit into
mainfrom
sr3-drv-bits
Nov 4, 2026
Merged

compot-dev merged 1 commit into
mainfrom
sr3-drv-bits

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

DRV0 and DRV1 are bits 5 and 6 of status register 3 (0x20, 0x40), as the Registers view of the web mode and the Android app has them; the constants said 0x08 and 0x10.

Neither constant is used: the native build has the same SHA-256 before and after, so this is no-release, with no new version. Build and tests pass in the container.

DRV0 and DRV1 are bits 5 and 6 of status register 3, as the Registers view
has them. Neither constant is used, the binary does not change.
@compot-dev compot-dev added the no-release Changes the build or the code without changing the binaries: no new version, no release label Nov 4, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Correct SPI NOR SR3 drive-strength bit masks

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Correct SR3_DRV0 and SR3_DRV1 masks to represent bits 5 and 6.
• Align the definitions with the Registers views; neither constant is currently used.
High-Level Assessment

Correcting the masks in place is the smallest appropriate fix. A broader register-handling change is unnecessary because neither constant is used.

Files changed (1) +2 / -2

Bug fix (1) +2 / -2
spi_nor_flash.cCorrect SR3 drive-strength masks +2/-2

Correct SR3 drive-strength masks

• Changes SR3_DRV0 from 0x08 to 0x20 and SR3_DRV1 from 0x10 to 0x40, matching bits 5 and 6. Neither definition is referenced elsewhere in the source.

src/spi_nor_flash.c

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev
compot-dev merged commit 436f70a into main Nov 4, 2026
13 of 14 checks passed
@compot-dev
compot-dev deleted the sr3-drv-bits branch November 4, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Changes the build or the code without changing the binaries: no new version, no release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant