Skip to content

Let physical observations select their bounded history copy - #1420

Merged
trissim merged 1 commit into
mainfrom
work/pi-typed-dispatch--P1092-copy-budget
Nov 2, 2026
Merged

trissim merged 1 commit into
mainfrom
work/pi-typed-dispatch--P1092-copy-budget

Conversation

@trissim

@trissim trissim commented Nov 2, 2026 •

Copy link
Copy Markdown

Summary

1 commit; 1 file, +2/-1. Physical observations can select a native CheckRoot subtype without copying the frontend lifecycle or patching a module global.

Before / after

Before: ObservedTerminalApp.copied constructs CheckRoot directly. Its fixed 200-record budget refuses the current selected history because the newest message's answered-original closure alone exceeds that budget.
After: the runner declares check_root_type: type[CheckRoot] = CheckRoot and constructs that declared type. An observation can inherit CheckRoot and override its existing finite max_records declaration. Ordinary callers retain the same type and budget.

What stays owned

CheckRoot still owns scope selection, answer closure, bounded transcript copying, private-root admission, and source preservation. ObservedTerminalApp still owns frontend setup, isolated display, startup, and retirement. No answer is trimmed to fit; an oversized selected closure still refuses. No alternate runner, global patch, or compatibility path was added.

Evidence

  • Original installed failure: /home/ts/.cache/agent-scratch/pi-typed-dispatch/dispatch-installed-physical-03.log, exit1 before frontend startup, at MessageDisplayScope.history's closure bound.
  • Full two-hunk diff read; AST parse succeeds; git diff --check succeeds. Native installed source trace: CheckRoot._populate passes the subtype's max_records into the existing history owner; _session retains the existing byte bound.
  • Corrected installed physical observation06 completed rc0 under Core0f8dcdbe5: eight native carrier/subscription controls, actual mailbox history publication, candidate entries1→0, all subscriptions closed. Screenshot read with no probe error notifications; frontend/Xvfb both stopped gracefully with exit0 and copied-root retirement recorded. This validates the copy hook in the existing lifecycle; it is not an ACP-view/provider journey or a performance result. Artifacts: /home/ts/.cache/agent-scratch/pi-typed-dispatch/dispatch-installed-physical-06.log and matching directory. Failed epochs03–05 remain retained.

Assumed: the observing subclass chooses an appropriate finite capacity; this hook does not certify that capacity is minimal or sufficient for every future history.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 19:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit d7429c1 into main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants