Repository navigation
Let physical observations select their bounded history copy - #1420
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 commit; 1 file, +2/-1. Physical observations can select a native CheckRoot subtype without copying the frontend lifecycle or patching a module global.
Before / after
Before:
ObservedTerminalApp.copiedconstructsCheckRootdirectly. Its fixed 200-record budget refuses the current selected history because the newest message's answered-original closure alone exceeds that budget.After: the runner declares
check_root_type: type[CheckRoot] = CheckRootand constructs that declared type. An observation can inherit CheckRoot and override its existing finitemax_recordsdeclaration. Ordinary callers retain the same type and budget.What stays owned
CheckRoot still owns scope selection, answer closure, bounded transcript copying, private-root admission, and source preservation. ObservedTerminalApp still owns frontend setup, isolated display, startup, and retirement. No answer is trimmed to fit; an oversized selected closure still refuses. No alternate runner, global patch, or compatibility path was added.
Evidence
/home/ts/.cache/agent-scratch/pi-typed-dispatch/dispatch-installed-physical-03.log, exit1 before frontend startup, atMessageDisplayScope.history's closure bound.git diff --checksucceeds. Native installed source trace:CheckRoot._populatepasses the subtype'smax_recordsinto the existing history owner;_sessionretains the existing byte bound./home/ts/.cache/agent-scratch/pi-typed-dispatch/dispatch-installed-physical-06.logand matching directory. Failed epochs03–05 remain retained.Assumed: the observing subclass chooses an appropriate finite capacity; this hook does not certify that capacity is minimal or sufficient for every future history.