Repository navigation
Conversation
|
debt-src at 52fdf78 passes. |
trissim
force-pushed
the
feat/native-remote-bus
branch
from
November 2, 2026 18:36
6d1b01e to
52fdf78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native remote-bus client — implementation in progress
First checkpoint: 12 files, +46/-19. The app constructor's unconditional local
CoordinationAccess(...)construction becomes one dispatch through the selectedCoreConnection.Current code
Before: both CLI paths and fixture producers pass a filesystem LaunchRoot directly to ToadApp; ToadApp always creates the local observer.
After: CoreConnection owns opening its transport's access. LocalCoreConnection inherits LaunchRoot and retains its existing path/launch behavior, supplying the local access constructor. ToadApp calls the connection. Both CLI paths, the common workspace fixture and its three application factories use the same constructor contract. Selected isolated observer fixtures preserve their real root values through that owner.
Still required on this PR
The remote connection/profile selection, MCP read transport, shared normal CommsChatView/WireSource page path and real remote-page acceptance remain to be implemented. This checkpoint does not provide a runnable remote UI and is not delivery of the native Termux target. No fake local root, proxy agent or copied Core bus is introduced.
Core prerequisites #3861 and #3884 have merged. The latter's actual captured-input carry/rollback passed with the credential lock held; its artifacts and installation scope are recorded on Core#3884.
Evidence
Source trace: CLI startup/ToadApp → CoreConnection.open_access → inherited LocalCoreConnection → unchanged CoordinationAccess local observation/selection lifecycle. All changed Python sources parse; diff whitespace check passes. Constructor searches cover src/tests/tools, including the top-row factory introduced by current main. Tests/application runs have not been executed for this checkpoint; no competing test/native/provider lane was started.
Assumed: local LaunchRoot path/argument semantics remain the existing contract; remote access will get its own real connection rather than borrowing a filesystem root. Physical Termux gesture and signer/backup acceptance remain separate from this client implementation.