Repository navigation
Land four-edge sidebars and queued editor intent - #1401
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
November 2, 2026 02:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Land sidebar placement and editor submission relief
Combines Toad #1391's 21-commit sidebar overhaul with the independently landable three-file editor-intent repair from #1389. Three integration commits on notification main41d3a2d22; 45 files, +1375/-753. Original author branches are preserved.
Sidebars and readable metadata
Keeps the four-edge placement, captured resize, retained sidebar resources, narrow metadata wrapping and current Checkout fixtures from #1391. Commander compared the qualified c688 source/tests against a0b9: no differences. Its existing eight focus/layout checks passed; phone/configured-arrival acceptance remains with UI after installation rather than gating this landing.
Notification integration
Resolved the sole conflict in MeasuredRows. Preserve main's rewrapped_plain and replaced_at methods, including in-place row replacement. Preserve #1391's synchronous theme-value equality policy; it calls the existing rewrapped_plain method rather than copying its body. Async current_for, retention and publication continue to require theme identity.
Editor intent belongs to its pending request
Carries dee9434 as de0a65a. PendingPromptSubmission owns the action and editing mode; taking it clears pending state before flush/refusal. A refused send-now cannot leak priority to later Enter, and queued Enter coalesces into one publication. No Core3848 dependency; the remaining submission overhaul stays on #1389.
Verification
The combined selection executed under the host TestLease, INT300 and no xdist: tests/textual/test_prompt_enter_insert.py plus test_wire_message_lines.py::test_divider_acquisition_reuses_equal_fades_rewraps_and_repaints_changed_styles. At de0a65a with Core65: 13 collected, 12 passed, one failed, 148.34s, exit1. The failure was the existing chooser fixture reading removed SettingsScreen.form; SettingsScreen.values already owns the actual chooser. Both refused-transfer cases, all three coalescing cases and the sole row-reuse conflict passed.
Commit0b451c8e2 changes only those two fixture accesses. The failed real Neovim save/reopen case then executed on Core2bc0d7a17: one collected, one passed, 18.14s, three warnings. This is a separate result, not a fabricated thirteen-case rerun. The original de0a production source also passed hosted NRA; its suite was intentionally skipped. No full suite or local NRA gate. Logs and exit records: /home/ts/.cache/agent-scratch/pi-commander/land-nov1/toad-tests02.* and toad-chooser03.*.
Assumed: existing Core65e7349cd and Textual contracts; original source acceptance retained except the explicitly reviewed conflict. Physical/phone acceptance is not claimed.