Repository navigation
Fix commander muted-tone colour ownership - #1392
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One existing owner correction; one file, +3/-3. Preserves the implementation from #1389 commit0262c1d8 without holding this demonstrated HUD crash behind unrelated integration controls.
Before / after
UnitTone.ordinary(MutedTone)returnedForegroundMutedColour, an optionalElementColour. Schemes may legitimately omit it, so the installed commander page raised five saved KeyErrors throughCommanderAlarm.present -> TextualColours.colour.It now returns
MutedColour, the existing semantic secondary-textBlendColour.MutedRolealready uses it.TextualColours.variables_changedderives every blend member for every scheme. No palette fallback, new registry or duplicated theme policy.Evidence and limits
Independently read UnitTone, ColourScheme required/optional admission, MutedColour and TextualColours population; actual existing owner returns the palette-admitted member. Retained installed failure: pi-publication-carry/toad-errors-2026-10-31/live-hud-acceptance/result.md under the owned scratch root. Before-run had five UI KeyErrors, zero malformed/RPC errors, and quit0. This is not an ACP fix.
No pytest/full suite/local gate claimed. Paired queue/refusal integration remains separate and RED (six unresolved controls); this PR changes none of those paths. Merger owns installation and actual default-launcher HUD rerun before application acceptance. P867 is not closed by this source correction.
Assumed: the existing universal blend contract remains authoritative; optional element overrides must not be promoted to mandatory palette entries.