Skip to content

Fix notification display lookup for live outgoing messages #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Oct 31, 2026
Merged

Fix notification display lookup for live outgoing messages #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/toad/block_navigation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from typing import TYPE_CHECKING, Callable, ClassVar, cast

from agent_comms.nominal.declared_family import DeclaredFamily
from agent_comms.read_basis import DisplayCut, NoDisplaySelection
from agent_comms.ui_model.message_category import MessageCategory, OtherCategory
from textual.geometry import Region
from textual.widget import Widget
Expand All @@ -17,6 +18,7 @@
from toad.widgets.presentation_window import NewerEnd, OlderEnd, PageEnd

if TYPE_CHECKING:
from agent_comms.message_reference import MessageReference
from agent_comms.ui_model.message_category import AgentActivityBoundary
from textual.screen import Screen

Expand Down Expand Up @@ -396,6 +398,10 @@ def repaint(self) -> None:
def notification_targets(self):
return ()

def notification_identity_for(self, references: frozenset[MessageReference]) -> DisplayCut:
"""Live entries have no captured BUS display cut; source rows override with theirs."""
return NoDisplaySelection()

@cached_property
def block_cursor(self) -> BlockCursor:
return AtomicBlockCursor(self)
Expand Down
Loading