Repository navigation
Repair the Toad suite: declared enter overlap first - #1385
Merged
Merged
Conversation
DeclaredTable(OpensSelected, DataTable) inherits SelectCursor on enter and takes the key with OpenSelectedAction first in its MRO. The behaviour was intended and never declared, so the keymap reported a conflict in its own defaults. The keymap tests picked f7 as a free key. TextArea owns f7 as Select all, so they now use f18, which nothing claims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
owner.worktree already is the Checkout; wrapping it in Path made on_mount raise, leaving a dead screen whose sidebar query then failed with NoMatches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed Mount was shown by ToadApp._handle_exception while Textual tore the tree down, but WorkspaceSessions.views kept it: select and close then raised NoMatches for the sidebar, naming the wrong thing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
722 tests on 2 workers reached 587 in the 60 minute cap, so every run was cancelled and the required suite check could not pass on any head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suite repair for #1375. The last suite run recorded 116 distinct failed tests across 69 files, and its cancelled log printed no reasons. This PR carries every commit for that issue.
Sample, one failing test per file, on main at 64c9906
68 ran: 59 still fail, 8 pass, plus 1 id I quoted wrongly (rc=4, it measured nothing). This covers one test per file, not all 116.
ReadLedger.seen_sequences,to_wire,original_root,Agent(app_events, transcripts),turn_idand others).NoMatches: SessionThreadSidebarfromclose_presentationatscreens/main.py:460, seen in 3 sampled tests;tests/app/test_prompt_routing.py('' == '!');tests/app/test_channel_mentions.py; key ordering intest_key_bursts_move_focus_to_the_editor.py('xy' == 'yx');test_navigation_keys.py(ctrl+shift+kdoes not clear the editor).This commit
OpenSelectedAction.permits_key_overlapdeclares that it may shareenterwithSelectCursor.DeclaredTable(OpensSelected, DataTable)atwidgets/declared_table.py:76already gave the key to opening through its MRO, so behaviour is unchanged and the keymap stops calling its own defaults a conflict.The keymap tests assumed
f7was free;TextAreaowns it as Select all, so they usef18.Evidence
tests/textual/test_keymap_model.py: 3 failed before, 6 passed after, run locally.tests/textual/test_keymap_screen.py,test_active_mode_keymap.py,test_commander_page.py: not verified. The local run was killed for low memory on the box. This PR's CI suite is the check.Owner of the next step: claude-board.
🤖 Generated with Claude Code