Repository navigation
Stop faking an event so one caller can consume a presentation - #1382
Merged
Merged
Conversation
thread_observed took ThreadRowsChanged | None so observe_thread could call it with nothing, and never read the event. The subscriber now takes its event and calls consume_thread_presentation; observe_thread calls that directly. Removes the NoneAbsence growth #1381 brought in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One fix: 2 files, +5/-2.
thread_observed(event: ThreadRowsChanged | None = None)carried a fake event soobserve_threadcould say "no event", and nothing read it. #1381 brought this in over a red NRA gate (grew NoneAbsence, run 41154053196).The subscriber now takes its event and calls
consume_thread_presentation().observe_threadcalls that directly. Behaviour is unchanged, and #1381's fix stays.Evidence: guards pass locally. #1381 shipped no test, so nothing here exercises the path except the suite.
🤖 Generated with Claude Code