Repository navigation
Give the suite time to finish so its failures can be counted - #1380
Merged
Merged
Conversation
The suite needs about 44 minutes on 2 workers (#1375) and was cut off at 30, around 70%, on every branch. No run has ever reported the last 30%. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
A 60-minute limit lets the suite report; it does not make it fast. These timings name what to fix next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Helpers inherit the child pytest's pipes and BoundedRun reads until they close, so a test whose app close failed reported in 13 s and then held its worker for the full 165 s. The child now stops its own helpers as it exits. 7 tests hit this on the last run, 1156 of 7006 worker seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suite fixes for #1375, in numbers: last run hit its 60-minute limit at 87%, 629 results, 117 failed, 7006 worker seconds. A whole run has never completed on any branch.
The 165-second hang
Helpers inherit the child pytest's pipes, and
BoundedRunreads until they close. A test whose app close failed reported in about 13 s, then held its worker for the full 165 s.pytest_unconfigurein the child now stops its own helpers.Before:
test_a_renamed_thread_keeps_its_hidden_session165 s. After: 18 s, still failing for its real reason (NoMatches: SessionThreadSidebar). Control: 4 of 4 pass. 7 tests hit this, 1156 of 7006 worker seconds.CI
suitegets 60 minutes and prints its 40 slowest. This is a stopgap: a 60-minute suite is the defect.Slowest tests (from log timestamps, because the cancelled run never printed durations)
test_hidden_session_retirement, 2 intest_saved_history_coverage, 1 intest_initial_prompt_handoff.Owner of the next step: claude-board.
🤖 Generated with Claude Code