Skip to content

Point stale queue and live-output tests at their owners - #1378

Merged
trissim merged 1 commit into
mainfrom
claude-nra-fork/main-reds
Nov 1, 2026
Merged

trissim merged 1 commit into
mainfrom
claude-nra-fork/main-reds

Conversation

@trissim

@trissim trissim commented Oct 30, 2026

Copy link
Copy Markdown

Red on main: 7 failed, 3 passed in test_queue_request_results + test_live_output_streams. Now: 10 passed, installed runtime core-dabeef407.

  • 4 queue reds: helper passed str to LiveQueueScope.session_id: AcpSessionId. Test defect.
  • 3 live-output reds: TurnOwner.response_stream and ResponseStream(turn_id=) are gone (94eda01). Same behaviour now asserted through CommsUpdateConsumer.response_stream, distinct source_claims and CompleteResponseStream. No source change, no test deleted.

toad#1368 touches neither file.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7

…heir API

LiveQueueScope.session_id is AcpSessionId; the helper passed a str. TurnOwner.response_stream
and ResponseStream(turn_id=) no longer exist since 94eda01 grouped text by its append claim;
the tests now take streams from CommsUpdateConsumer and vary source_claim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7
Copilot AI balanced review requested due to automatic review settings October 30, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 31, 2026

Copy link
Copy Markdown
Author

Original55cf retained in owned integration2dc2102 and combined branch integ/queue-refusal-and-salvage at7bab354b with #1389. Main nominal imports plus the sibling AcpSessionId fixture corrected; production unchanged by1378 salvage. Commander runs the three affected paths with paired refusal controls. No author branch rewrite or old test-count acceptance.

@trissim
trissim merged commit 2dc2102 into main Nov 1, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants