Skip to content

P1032: repaint channel members only for changed pins #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 30, 2026
Merged

P1032: repaint channel members only for changed pins #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a7a415
P1032: repaint channel members only for changed pins
trissim Oct 30, 2026
021b3d3
Merge remote-tracking branch 'origin/main' into work/toad-sidebar--P1032
trissim Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/toad/widgets/comms_sidebar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def __init__(self, row: CommsRow, *, expanded: bool):
def sidebar(self) -> CommsSidebar:
return self.query_ancestor(CommsSidebar)

def present(self, channel: ChannelRowModel) -> None:
"""Paint the channel header from its model row."""
def present(self, channel: ChannelRowModel) -> frozenset[str]:
"""Paint the header and return members whose channel pin changed."""
previous, self.channel = self.channel, channel
row = self.row
if previous.label != channel.label:
Expand All @@ -113,6 +113,7 @@ def present(self, channel: ChannelRowModel) -> None:
self.unread_badge.update(label, layout=width_changed)
self.unread_badge.display = bool(label)
self.sort_control.update_order(channel.order)
return previous.pinned_members ^ channel.pinned_members

def toggle_members(self) -> None:
super().toggle_members()
Expand Down
3 changes: 1 addition & 2 deletions src/toad/widgets/sidebar_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,7 @@ def apply_comms(self, sidebar: CommsSidebar, rows: Mapping[str, ChannelRowModel]
for name in self.names:
group = sidebar.groups.get(name)
if group is not None:
group.present(rows[name])
group.sync_members(frozenset(group.member_keys))
group.sync_members(group.present(rows[name]))

def apply_welcome(self, channel_list: SidebarGroup, thread_list: SidebarGroup) -> None:
channel_list.sync_members(self.names)
Expand Down
Loading