Repository navigation
Relock Core so Toad's tests import DetachedChildStdio from its owner - #1358
Merged
Merged
Conversation
…its owner Toad main pinned agent-comms 8d2055268, before fc770bee5e moved DetachedChildStdio into native_build_inputs, while tests/textual/test_compaction_turn_events.py:12 already imports it from there. Every Toad suite run errored at collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Toad suite run errored at collection:
ImportError: cannot import name 'DetachedChildStdio' from 'agent_comms.native_build_inputs'(run 41016985257). Toad main pinned agent-comms 8d2055268, which predates fc770bee5e moving DetachedChildStdio into native_build_inputs, while tests/textual/test_compaction_turn_events.py:12 already imports from the new owner.Fix: relock agent-comms to main df88496b (uv lock --upgrade-package agent-comms). One file, uv.lock (+16/-7). Also pulls nominal-refactor-advisor d0667af3 and python-introspect f2876b9e as resolved.
Checked: every
from agent_comms.X import Yin Toad src/tests/tools resolves at df88496b (AST scan against git show); the three names #3589 deleted (BoardRow/HudRow/QuietUnits) are already gone from Toad main via #1321.🤖 Generated with Claude Code