Repository navigation
Reclaim Figure 3 spacing and enlarge Figure 6 body views - #1277
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give image pixels the space, not the padding
Two requested layout repairs in one change:
Owners and before/after
Class structure is unchanged:
BenchmarkFigure(FigureSheet)andAnalysisResultsFigure(VolumeResultsFigure), withVolumeResultsFigure(SupplementFigure)retaining responsibility for the retinal/body layout.FigureSheetstill validates retained artwork hashes, preserves aspect and records editorial crops. No new renderer, helper, registry, data source or compatibility system.Before: G was a reduced wide composite with large side gutters; H's tall crops were centred in short wide boxes. After: the same first retinal row is separated into its three complete retained image tiles (including20µm bars), stacked at left; H uses the right-hand strip at the native crop aspect. The four H crop coordinates and10-voxel bars are unchanged. E/F move slightly upward to make room; E's F1 annotation moves to its heading and uses compact decimal formatting, without changing either score.
No image selection, contrast, labels, scale calibration, quantitative result, measurement/timing source, text/caption or scientific interpretation changes. The old placements are replaced in place; the historical source artwork remains immutable scientific evidence.
Verification
submission_benchmark_summary()andsubmission_summary()entrypoints, existing papers-only environment only; no scientific/model/benchmark reruns.run-20261030T233628-2724705c; exact reader SHA256:50e6e776fdbc4358abe073062e54a1372bdb0b225575eb1786a6e711c1c7f872. No rebuild is needed for publication./home/ts/.cache/agent-scratch/openhcs-paper/spacing-gh-{source-proof.json,inspect.log,visual-acceptance.md}andspacing-gh-pages/package.json.Exact commands and results
Using the existing
/home/ts/code/projects/papers-only/.venv/bin/python, without creating or syncing an environment:PYTHONPATH=/home/ts/code/projects/papers-only:.:paper/figures python -c 'from build_slas_benchmark_reference import submission_benchmark_summary; from build_slas_task_only import submission_summary; submission_benchmark_summary(); submission_summary()' PYTHONPATH=/home/ts/code/projects/papers-only python paper/build_paper.py build --candidate PYTHONPATH=/home/ts/code/projects/papers-only python spacing_inspect.pyAll exited0. The one-shot inspection verified all343manifest artifacts/153commands, located Figures3/6, rendered manuscript/reader pages17/21 at150dpi, and proved the corresponding page images identical before personal visual inspection. Its source was removed after that one run. No full test suite, local NRA gate or benchmark execution.
Merged, exact-byte published, checkout retired
Merged as
ce73ee93eb9d60fe6215723547654dc9abeb2940; final-head hosted structural-ratchet and nra-r1 both succeeded. Independently matched all834 merged-main inputs and tool identities, then published the343 exact inspected artifacts without rebuilding. Reader remainsfile:///home/ts/code/projects/openhcs/paper/current/openhcs_review.pdf, statecurrent, changed[]; its SHA256 equals the accepted value above.Preserved470 user untracked files/modes and all343 prior-release artifacts. Both one-shot helper sources are removed; the clean goal checkout and duplicate candidate were retired through supported
goal-checkout removeafter remote and actual process/mount borrower checks. Canonical accepted build, original inspected manifest and visual acceptance remain inpaper/build/run-20261030T233628-2724705c. Concise publication/retirement evidence is retained besidespacing-gh-publication.jsonandspacing-gh-retirement.jsonin the stated scratch directory. Canonicalgit diff --stat origin/main...HEADis empty. Available disk is back to approximately11GiB.Assumed: G continues to show the first retained retinal region, and H the exact existing Z36 body views; no new field is selected.