Skip to content

Give Figure 3 panel B the space occupied by the side legend - #1276

Merged
trissim merged 2 commits into
mainfrom
work/openhcs-paper-legend-below
Oct 30, 2026
Merged

trissim merged 2 commits into
mainfrom
work/openhcs-paper-legend-below

Conversation

@trissim

@trissim trissim commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Figure 3 uses the freed top-row width

One layout change: the five-entry coverage legend moves below the donut, and panel B grows from 37% to 53% of canvas width (+43.2%). Typography, data, statistics, axes, units and A/B/C letters stay unchanged.

Existing owner, changed layout

Before/after class structure is unchanged: BenchmarkFigure(FigureSheet). The layout is edited in submission_benchmark_summary(); there is no new renderer, registry, helper or compatibility path.

The old side-legend placement is replaced in place. The donut is above its coverage legend in the left column; panel B uses the space the legend occupied. Panel C is unchanged. The 85-module total remains 54 workflow, 29 individual and 2 shared-code-only modules, with both zero-count categories retained.

Verification

  • Ran the existing submission_benchmark_summary() using the existing papers-only environment, without rerunning benchmarks or changing scientific inputs: exit 0.
  • Inspected the generated full figure: all five legend entries sit below the donut, the widened B plot and summary rows do not overlap the legend, and C is unchanged.
  • Built the candidate documents through the existing paper/build_paper.py build --candidate:834 inputs,343 matching artifacts,153 exit0 commands. Manuscript29pages, supplement22, reader50.
  • Personally inspected placed Figure3 on page17 of both the manuscript and combined PDF at150dpi: legend below donut, no overlap with B's y-axis/summary rows, labels readable, C and caption intact. Accepted exact reader SHA256 f4198d581c056b071da39fb12378904f65c83bbee8f012584d0502f5acca46ea.
  • git diff --exit-code origin/main -- paper/figures/slas/submission_benchmark_summary_projection.csv passes: retained timing values unchanged.
  • Source changes:6 lines replaced; total5files includes the generated PNG,SVG,PDF and provenance. No manuscript prose changes.
  • One-shot package inspection script is removed after its single successful run. Full commands/results retained at /home/ts/.cache/agent-scratch/openhcs-paper/legend-below-{render,build,inspect}.log; visual acceptance beside them.

Published and retired

Merged as a553a74c6d4f52b561b38ec24bac6e8f8bc8e05c. Final-head hosted structural-ratchet and nra-r1 both succeeded.

Independently matched all834 merged-main input fingerprints and tool identities, then published the exact343 accepted artifacts without rebuilding. Current reader: file:///home/ts/code/projects/openhcs/paper/current/openhcs_review.pdf; state current, changed []. Preserved470 user untracked files/modes and343 prior-release artifacts. Reader hash matches the accepted value above.

Removed both owned one-shot helpers and retired the isolated goal checkout after proving the branch was pushed and no process or mount borrowed it. Canonical accepted build remains paper/build/run-20261030T224014-dee8e879 with the original inspected manifest and visual acceptance. Scoped cleanup restored available disk to approximately11GiB. Publication and retirement evidence: legend-below-publication.json, legend-below-retirement.json and corresponding logs beside the acceptance record.

git diff --stat origin/main...HEAD on canonical main: empty after fast-forward. Source PR scope:5files,+619/−619, including generated SVG coordinates;6 actual source lines replaced. No new semantic system or scientific result.

Assumed: this request concerns the main-paper Figure 3 coverage donut; confirmed against its existing source and prior published page. No new scientific or timing claims.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 22:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit a553a74 into main Oct 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants