Repository navigation
Connect selected capture requests to the held installer worker (P1086) - #3897
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-tools at c880c7c passes. |
|
debt-src at c880c7c passes. Warn-only, never blocks (4) |
trissim
force-pushed
the
fix/p867-recorded-source
branch
from
November 2, 2026 20:54
530f257 to
c880c7c
Compare
trissim
enabled auto-merge
November 2, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1086 successor to #3829: connect selected requests to the held worker
One continuing repair commit; seven files; +98/-32. The original pushed checkpoint is788302a4a8. This PR carries the request consumer missing from the merged #3829 operation. The original implementation and preservation responsibility stay with the same owner. Commander corrected the merged-PR restriction in bus57197; the existing source-delivery claim and original-data comparison records remain intact.
Before → after
Before:
SelectedInputsProbeexisted, but no CLI/launcher request reached it inside the shared installer hold.InstallRun.runseparately forwarded the request's options toupgrade.After:
InstallRequest.selected_inputsowns--selected-inputs, a JSON array of the existing typed probes with an empty default.InstallRun.run → upgrade(command, ...)carries the request declaration instead of another option list.mode.owners_stopped/retargeted maintenance lifetime enclosesstaged.probebeforemember.rehearsedtakes the first complete rehearsal copy.RehearsedUpgrade.captured_inputsretains the resulting measurements. Rehearsal-only mode gains no capture authority; the probe's existing hold refusal remains in force.InstallRequest. A narrow CLI/launcher regression is authored intests/test_retained_capture.py; documentation distinguishes historical verification from the current remaining work.The operation finally has a route to its worker. Previously the doorbell had no door.
Source and supporting evidence
The exact original P1086 selected request was decoded by the actual CLI and launcher record using the installed Python3.14.8 and this checkout's source. Selected values, empty defaults and measurement values round-tripped; five changed Python files parsed. rc0; capture executed:false; destination created:false. The five checked source hashes matched the committed checkpoint after rebase.
The earlier check compared CLI subclass identity with the decoded base request and failed. The corrected check compares the declaration-owned request values; both epochs remain retained in
shared-board/p1086-request-codec-{01,02}.{log,rc}and their owned-checkout drivers. This is a request/codec proof, not a held-worker or fresh native application run.The source trace is
InstallRequest → InstallRun.run → upgrade → mode.owners_stopped → staged.probe → SelectedInputsProbe.run → PracticeCopy.capture_inputs. The existing operation owns the maintenance/runtime/registry/source checks and selected allowance. No second freezer, selector, schema or compatibility path is introduced.Still open under P1086
The new regression and affected installer/rollback execution have not been run here; the existing combined-execution owner retains them. Hosted checks and exact-head review remain required.
Original-data materialization, resource peaks, ordinary context/canonical unresolved/native session-and-path/participant comparisons, and the original configured-native/isolated-physical reader journey remain open. The original coordinates and3GiB selected allowance are retained. Neither this PR nor #3829's source delivery claims that application acceptance.
Assumed: this optional operation is requested only through the real shared installer hold. Ordinary installs keep the empty default; ordinary complete practice copies retain their existing separate space policy.