Skip to content

Connect selected capture requests to the held installer worker (P1086) - #3897

Merged
trissim merged 1 commit into
mainfrom
fix/p867-recorded-source
Nov 2, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/p867-recorded-source

Conversation

@trissim

@trissim trissim commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

P1086 successor to #3829: connect selected requests to the held worker

One continuing repair commit; seven files; +98/-32. The original pushed checkpoint is788302a4a8. This PR carries the request consumer missing from the merged #3829 operation. The original implementation and preservation responsibility stay with the same owner. Commander corrected the merged-PR restriction in bus57197; the existing source-delivery claim and original-data comparison records remain intact.

Before → after

Before: SelectedInputsProbe existed, but no CLI/launcher request reached it inside the shared installer hold. InstallRun.run separately forwarded the request's options to upgrade.

After:

  • InstallRequest.selected_inputs owns --selected-inputs, a JSON array of the existing typed probes with an empty default.
  • InstallRun.run → upgrade(command, ...) carries the request declaration instead of another option list.
  • The existing mode.owners_stopped/retargeted maintenance lifetime encloses staged.probe before member.rehearsed takes the first complete rehearsal copy.
  • RehearsedUpgrade.captured_inputs retains the resulting measurements. Rehearsal-only mode gains no capture authority; the probe's existing hold refusal remains in force.
  • Both direct test callers use InstallRequest. A narrow CLI/launcher regression is authored in tests/test_retained_capture.py; documentation distinguishes historical verification from the current remaining work.

The operation finally has a route to its worker. Previously the doorbell had no door.

Source and supporting evidence

The exact original P1086 selected request was decoded by the actual CLI and launcher record using the installed Python3.14.8 and this checkout's source. Selected values, empty defaults and measurement values round-tripped; five changed Python files parsed. rc0; capture executed:false; destination created:false. The five checked source hashes matched the committed checkpoint after rebase.

The earlier check compared CLI subclass identity with the decoded base request and failed. The corrected check compares the declaration-owned request values; both epochs remain retained in shared-board/p1086-request-codec-{01,02}.{log,rc} and their owned-checkout drivers. This is a request/codec proof, not a held-worker or fresh native application run.

The source trace is InstallRequest → InstallRun.run → upgrade → mode.owners_stopped → staged.probe → SelectedInputsProbe.run → PracticeCopy.capture_inputs. The existing operation owns the maintenance/runtime/registry/source checks and selected allowance. No second freezer, selector, schema or compatibility path is introduced.

Still open under P1086

The new regression and affected installer/rollback execution have not been run here; the existing combined-execution owner retains them. Hosted checks and exact-head review remain required.

Original-data materialization, resource peaks, ordinary context/canonical unresolved/native session-and-path/participant comparisons, and the original configured-native/isolated-physical reader journey remain open. The original coordinates and3GiB selected allowance are retained. Neither this PR nor #3829's source delivery claims that application acceptance.

Assumed: this optional operation is requested only through the real shared installer hold. Ordinary installs keep the empty default; ordinary complete practice copies retain their existing separate space policy.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

debt-tools at c880c7c passes.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

debt-src at c880c7c passes.

Warn-only, never blocks (4)
src/agent_comms/installer/request.py: LintFindings +1
src/agent_comms/installer/upgrade.py: LintFindings +1
found LintFindings:src/agent_comms/installer/request.py at src/agent_comms/installer/request.py:47 (E501 Line too long (111 > 100))
found LintFindings:src/agent_comms/installer/upgrade.py at src/agent_comms/installer/upgrade.py:825 (E501 Line too long (101 > 100))

@trissim
trissim force-pushed the fix/p867-recorded-source branch from 530f257 to c880c7c Compare November 2, 2026 20:54
@trissim
trissim enabled auto-merge November 2, 2026 21:13
@trissim
trissim added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 8c478c3 Nov 2, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants