Repository navigation
Run one native roundtrip in the private-runtime isolation control - #3895
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One file,+4/-1; nested native bus-path cases7→1. The private-runtime qualification keeps its real saved-owner DM/proof roundtrip and every live-home/publication/cleanup assertion. Queue, steer, cancellation and stalled-provider cases remain in their ordinary native test module.
Before / after
Before,
test_checkout_native_tests_use_a_private_runtimebuilt the private stack, then invoked the entiretest_native_input_bus_path.pyinside pytest. The full suite also executes those seven cases directly.After, the isolation control selects
test_saved_owner_dm_replies_and_core_reads_exact_native_proof: actual saved history, native owner, fresh bus DM, one provider response, exact bus-owned proof row and retired child. Its surrounding isolation assertions are unchanged.The command forwards this existing node ID through
installer.test_runtime.main(parse_known_args) →RuntimeStack.test(*arguments)→ installed-interpreter pytest. No product API or selector machinery changes.Source evidence
git diff --checkpasses.Timing scope
The old hosted run41459287846/job125323898243 has a176.39s same-worker completion gap at this control. This includes possible setup/scheduling/output delay and is a cost lead, not an exact test duration. The direct affected run will record this head's actual result/time. Full-suite after-run41503772484 on3893's merge04c174d6e8d2 is separately in progress; the39m19s baseline and halving target remain open.
Assumed: one actual native roundtrip establishes the private command's runtime/publication isolation; queue/steer/cancel behavior belongs to the native bus-path family and remains independently tested there.