Skip to content

Run one native roundtrip in the private-runtime isolation control - #3895

Merged
trissim merged 1 commit into
mainfrom
cleanup/private-runtime-test
Nov 2, 2026
Merged

trissim merged 1 commit into
mainfrom
cleanup/private-runtime-test

Conversation

@trissim

@trissim trissim commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Summary

One file,+4/-1; nested native bus-path cases7→1. The private-runtime qualification keeps its real saved-owner DM/proof roundtrip and every live-home/publication/cleanup assertion. Queue, steer, cancellation and stalled-provider cases remain in their ordinary native test module.

Before / after

Before, test_checkout_native_tests_use_a_private_runtime built the private stack, then invoked the entire test_native_input_bus_path.py inside pytest. The full suite also executes those seven cases directly.

After, the isolation control selects test_saved_owner_dm_replies_and_core_reads_exact_native_proof: actual saved history, native owner, fresh bus DM, one provider response, exact bus-owned proof row and retired child. Its surrounding isolation assertions are unchanged.

The command forwards this existing node ID through installer.test_runtime.main (parse_known_args) → RuntimeStack.test(*arguments) → installed-interpreter pytest. No product API or selector machinery changes.

Source evidence

  • NRA original/canonical projection:4directly traced modules,4classes,zero parse omissions; not a complete dependency map.
  • Typed confirmed these installer test files are outside Repair source publication observation and same-carrier recapture #3873's TestSelection changes (57147); the integration implementation remains with Typed.
  • git diff --check passes.
  • Affected execution: the one outer private-runtime qualification, under Core pytest's existing test lease.

Timing scope

The old hosted run41459287846/job125323898243 has a176.39s same-worker completion gap at this control. This includes possible setup/scheduling/output delay and is a cost lead, not an exact test duration. The direct affected run will record this head's actual result/time. Full-suite after-run41503772484 on3893's merge04c174d6e8d2 is separately in progress; the39m19s baseline and halving target remain open.

Assumed: one actual native roundtrip establishes the private command's runtime/publication isolation; queue/steer/cancel behavior belongs to the native bus-path family and remains independently tested there.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 18:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit bad8d80 Nov 2, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants