Repository navigation
Hotfix: install releases carry writer locks before services restart - #3889
Merged
Merged
Conversation
live() entered services_stopped inside borrowing(), so services restarted and the connector's ServingProbe ran while the installer held the carried stores' writer locks. With #3861's connector_access_carry pending, the probe's MCP round trip could not read the credentials store ("store lock busy, held by" the installer itself): install 6e8a33d5 failed, and its restore failed the same way. The writer locks now span carry, publish and input retirement only; services restart after they are released, on success and on restore alike. Retirement moves before the restart, still under the locks and still before the rollback point's end. No carry or credential behavior changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdttfQjtizEYZGek9Gh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix, 1 file, +12/−10 in
installer/upgrade.py. No change to carries or credentials. #3861's credential carry and #3884's backup fix stay exactly as merged.Failure (install 6e8a33d5, target 40294a2)
ExistingBusInstall.live()enteredservices_stoppedinsidestaged.borrowing(writer_declarations). Both the forwardstopped.start_on(...)and the restore-on-exitstart_servicesranServingProbewhile the installer held the carried stores' writer locks.borrowing()takes no locks when nothing is pending, so this ordering stayed latent until #3861'sconnector_access_carry: the first pending carry whose writer declarations include a store the connector reads, its credentials, to authenticate the probe's MCP call.Repair
services_stoppedis now the outer context andborrowingthe inner one, so on every exit the locks release before the stopped services restart.after_acceptance) right after publish, still under the locks, then closes them, clears maintenance and starts services.Evidence
tests/test_install_rehearsal.py tests/test_install_announcements.py tests/test_host_services.py tests/test_carry_connector_access.py: 40 passed, 4 failed and 18 errors, identical on main in this container. Every failure and error isGitVersionUnsupported(the container has Git 2.43, and Core requires 2.44), so the live-path controls are unrun here.Generated by Claude Code