Repository navigation
Repair stale consent and session lifecycle fixtures - #3881
Merged
Merged
Conversation
trissim
force-pushed
the
fix/consent-session-fixtures
branch
from
November 2, 2026 18:07
1680ed0 to
501f974
Compare
trissim
marked this pull request as ready for review
November 2, 2026 18:07
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
November 2, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair seven reported fixture failures across checkout, renamed-owner and ACP scenarios. The assertions continue to check dirty-work retention, stale-grant refusal, incarnation separation, persisted service-tier selection and same-project name allocation.
Holder consent
The checkout scenarios withdraw
worker's assignment as that actual holder.Assignment.require_release/require_consent(todos.py:3759-3773on the original base) remain the authority. Both native/external parameterizations keep their checkout and stale-grant assertions.Deletion lifecycle
The renamed-runtime scenario unregisters its synthetic owner and calls
ThreadManagement.delete. That owner holds the deletion claim, checks owned resources, removes state and completes throughRegistryDocument.remove_originals. The stale proxy still must reject a same-name new incarnation.ACP catalog and session ownership
A shared
session_projectfixture supplies an existing private project directory.The service-tier test requests the real configuration owner's
send_menupublication into RecordingClient.SessionLifecycle.new_sessionpublishes session metadata, then starts the separate menu producer;NewSessionResponse.config_optionsis not the menu authority. Selection and persistence assertions remain unchanged.The same-directory test starts the actual in-process RuntimeServer. Its owner-stop RPC runs through
asyncio.to_thread, allowing that server's event loop to process the stop, andCommsAgent.shutdownjoins cleanup.Evidence
Original failures: pi-toad-errors/delivery-owned/p1090-captured-controls-01/{core-model,test_acp,test_runtime}.log.
Source traced through assignment consent, permanent deletion, SessionLifecycle, SessionConfigOptions and runtime socket ownership. Bounded NRA original-syntax/canonical projection:13modules,338classes,zero parse omissions. This is the affected source boundary, not a whole-suite test classification.
Execution: the first local launcher duplicated the pytest-owned lease and was interrupted before collection. The corrected direct seven-case launch returned UNKNOWN and its intended log is absent. Its original request is preserved for admission recovery. Execution success remains unrecorded.
Assumed: these tests own their private roots. Original failed roots and uncertain inputs are preserved.