Skip to content

Repair stale consent and session lifecycle fixtures - #3881

Merged
trissim merged 2 commits into
mainfrom
fix/consent-session-fixtures
Nov 2, 2026
Merged

trissim merged 2 commits into
mainfrom
fix/consent-session-fixtures

Conversation

@trissim

@trissim trissim commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Repair seven reported fixture failures across checkout, renamed-owner and ACP scenarios. The assertions continue to check dirty-work retention, stale-grant refusal, incarnation separation, persisted service-tier selection and same-project name allocation.

Holder consent

The checkout scenarios withdraw worker's assignment as that actual holder. Assignment.require_release / require_consent (todos.py:3759-3773 on the original base) remain the authority. Both native/external parameterizations keep their checkout and stale-grant assertions.

Deletion lifecycle

The renamed-runtime scenario unregisters its synthetic owner and calls ThreadManagement.delete. That owner holds the deletion claim, checks owned resources, removes state and completes through RegistryDocument.remove_originals. The stale proxy still must reject a same-name new incarnation.

ACP catalog and session ownership

A shared session_project fixture supplies an existing private project directory.

The service-tier test requests the real configuration owner's send_menu publication into RecordingClient. SessionLifecycle.new_session publishes session metadata, then starts the separate menu producer; NewSessionResponse.config_options is not the menu authority. Selection and persistence assertions remain unchanged.

The same-directory test starts the actual in-process RuntimeServer. Its owner-stop RPC runs through asyncio.to_thread, allowing that server's event loop to process the stop, and CommsAgent.shutdown joins cleanup.

Evidence

Original failures: pi-toad-errors/delivery-owned/p1090-captured-controls-01/{core-model,test_acp,test_runtime}.log.

Source traced through assignment consent, permanent deletion, SessionLifecycle, SessionConfigOptions and runtime socket ownership. Bounded NRA original-syntax/canonical projection:13modules,338classes,zero parse omissions. This is the affected source boundary, not a whole-suite test classification.

Execution: the first local launcher duplicated the pytest-owned lease and was interrupted before collection. The corrected direct seven-case launch returned UNKNOWN and its intended log is absent. Its original request is preserved for admission recovery. Execution success remains unrecorded.

Assumed: these tests own their private roots. Original failed roots and uncertain inputs are preserved.

@trissim
trissim force-pushed the fix/consent-session-fixtures branch from 1680ed0 to 501f974 Compare November 2, 2026 18:07
@trissim
trissim marked this pull request as ready for review November 2, 2026 18:07
Copilot AI balanced review requested due to automatic review settings November 2, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim enabled auto-merge November 2, 2026 18:12
@trissim
trissim merged commit faec4bc into main Nov 2, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants