Skip to content

P1086: qualify selected original-input retention from 3829 - #3871

Closed
trissim wants to merge 29 commits into
mainfrom
work/pi-publication-carry--P1086
Closed

trissim wants to merge 29 commits into
mainfrom
work/pi-publication-carry--P1086

Conversation

@trissim

@trissim trissim commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

P1086: qualify the existing selected-input retention repair

This is the separate source-cut carrier for the existing repair in agent-comms#3829, not a second implementation. The source head is 7a2b1f5c791953f40127f7ff71804445e06d5b54 (26 commits; 39 files, +2860/-186 relative to its recorded base). It was combined without conflicts with main 3872d91ae52792f2a7f61e17aa81b51c25557604 in Core's allocated /home/ts/wt/pi-publication-carry--P1086 worktree. The resolved combination is 7da92df5e33ae1fa0cb1598cbf009c9a8824e327; both original parents remain in Git. The original source checkout is tracked-clean and unchanged. The installed producer supplies the actual captured source identities below; this prose cannot replace them.

Why the repair exists

Independently copying the complete bus/ledger and selecting contexts/coordinator groups can otherwise combine different original states. A whole original context/coordinator copy exceeds the selected-copy allowance. The repair retains selected original data through the existing table declarations and one real retargeted maintenance hold, beginning before the first complete-reader copy.

Structure

Before: selected readers could be copied at different cuts; required context history and coordinator children were supplied by incomplete entry-only selection.
After: InputCaptureFile(RootFile) and CompleteInputReader(InputCaptureFile) declare membership on the file owners. PracticeCopy.capture_inputs owns the common capture lifetime and calls the original readers and declared table closure. SelectedInputsProbe(TargetProbe, RuntimeProbe[PracticeMeasurement]) is the target-interpreter consumer. No new writable ledger, file roster, source overlay or compatibility loader is introduced.

Canonical SnapshotInputDispositions.unresolved(entries) still decides unresolved inputs, including uncertainty without a ledger entry and completed-attempt suppression in every ledger state. Retention keeps original births, full references, authentic producers, session AND path joins, requests, versions, predecessors, required child groups, annotations and grants. NoMaintenanceHolder.acting() prevents source writes during materialization. Ordinary complete backups remain complete and uncapped; the 10GiB free-space floor is unchanged.

Existing evidence, with its actual scope

  • Historical affected selection: 125/125 in 21.65s, rc0, before subsequent rebases.
  • File-capability selection: 19/19 in 4.97s, rc0, on its recorded earlier source.
  • Candidate interpreter-worker transport: 1/1 in 5.45s, rc0; a private fixture, not an original-data or native-agent run.
  • The later test-cleanup rebase kept production bytes unchanged and preserved main's shared fixtures. No historical run is relabeled as execution of this carrier.
  • Prior failed epochs and protected-original evidence remain retained under the existing pi-publication-carry scratch records. No failed or UNKNOWN input was replayed.

Remaining proof and actual risk

The unresolved interaction is the common-cut selected-retention operation against original bus, complete input ledger, context and coordinator data on the newly captured stack. Its next affected execution must cover source write exclusion, original identity/history preservation, ordinary-reader equivalence and selected-copy resource bounds.

This publication performs source qualification only. It does NOT claim current execution, merge permission, installation of #3829, original-data/native/physical acceptance, or successful completion of P1086. Original P867/P667/B4 orders, activity, drafts, reader return/reopen, real DM read AND edit, configured-native and isolated physical behavior remain open. Aggregate/temp/WAL/journal/handles/RSS/free-space evidence must establish the 3GiB selected-materialization cap without weakening it. A class-count check is not that proof.

Boundaries

No donor disposal, scientific/DQDock cleanup, original-store mutation, private-auth change, user-desktop input, phone migration, new agent or additional paid provider. Frozen roots remain non-runnable. Heartbeat publication stays Off.

Assumed: source review applies only to #3829's exact recorded head; historical tests retain their earlier epochs; the producer's canonical capture must independently establish freshness, repository scope and source containment. No untested native or recovery edge is promoted by this carrier.

Prepared source identities (not execution):
{"kind":"unpublished","predecessor":{"commit":"7da92df5e33ae1fa0cb1598cbf009c9a8824e327","repository":"openhcsdev/agent-comms"},"sources":[{"baseline":{"commit":"3872d91ae52792f2a7f61e17aa81b51c25557604","repository":"openhcsdev/agent-comms"},"candidate_tree":"f6e87cae9857c1f5454f9b9e67d3fe65472def93","heads":[{"head":"7a2b1f5c791953f40127f7ff71804445e06d5b54","pr":3829,"repo":"openhcsdev/agent-comms"}],"kind":"local_integration"},{"baseline":{"commit":"b67c97e5c3ad1eda5c06a464fdc578038d01e3e8","repository":"openhcsdev/formbridge"},"candidate_tree":"8632c131ec6c529cae78de44d86e191dbbbd844a","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"60138d533ef0758c5f093d9110ba9f5656f0934a","repository":"openhcsdev/metaclass-registry"},"candidate_tree":"3c11508a7bf34cfbe79964127305e056227b6b56","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"da87b77f22bd032bf7cd6d52630f684fa4a2b320","repository":"openhcsdev/textual"},"candidate_tree":"69923b8856c78a1053ca02d045f5b23e875a2c5b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"58c6ca55b09a250b872f8d9323cefad76b09aec9","repository":"openhcsdev/toad"},"candidate_tree":"aba05d441f89f32758f25638a46bf6c7815fde8b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"ba614bcb90b38c1f70789059a3c6aef8c017971b","repository":"openhcsdev/ui-theme"},"candidate_tree":"6a6cbe340cdd660e3d59cd086b15566d8836a0a2","heads":[],"kind":"merged_integration"}]}

Type the harness hook and remove its new low-level type-only/error-import detours. The unallocated SQLite ID owns numeric refusal; both annotation sorts use it. Participant reads use the existing required-row decoder and preserve domain missing-row refusal. One unrun original-ID case added.

Source-only: NRA syntax/compilation of six files, zero omissions; no Core subjects/MRO/SQL/store/pytest/provider execution. Hosted debt-src at parent is red; remaining import/native projection findings and preservation/application qualification remain open on same #3829.
NRA source snapshots and compilation: five production modules plus one test, no omissions. Existing membership-query prefix is AST-identical; 85 existing annotations unchanged. Source checks only; no Core, MRO, SQL, store or test execution. Existing 29 authored scenarios still need the combined run.
The actual frozen90 integration run collected75:45pass/24fail/6setup errors. The selected-loading writer now enables the URI capability already used by reconcile; read-only ATTACH and rollback remain unchanged. Harness fixtures decode real UUID spellings; unresolved inputs receive actual registry entries. Incomplete-aggregate controls start with real owner registration and explicitly model foreign corruption by removing/restoring only the declaration-derived delete guard, keeping insertion membership intact and requiring schema before retention.

NRA parsing and compilation of three changed modules:0 omissions,rc0. No author Core imports/MRO/SQL/pytest/provider execution. The original failed run is retained; corrected behavior and the wider original-data/native/physical journey are unverified.
The75-case891bc2 integration result is70passed/5failed/rc1. Four corruption controls asked only the base coordinator schema to validate a private root; use schema_at(source.path). The context control compared a restored read with a writer object before contributor JournalProvenance restoration; compare the complete original-store resolve at the selected source/record with the complete retained resolve. All coordinates, guard restoration, refusals, digest and allocation checks remain.

Two test modules parsed and compiled through NRA, zero omissions, rc0. No product edits or author Core/SQL/pytest/provider execution. Both failed epochs retained; corrected behavior and original-data/native/physical acceptance remain unverified.
PracticeCopy pins selected source groups and drains each admitted writer separately before acquiring the original registry cut. No SQL lock is held while seeking another or the registry. Existing maintenance members own target/holder admission and unchanged-generation refusal. Source observations reject holder-side writes before accepting the materialization. Complete include and backup behavior is unchanged.

Authored13 real-owner controls for admission, each of the four source writers, original registry association, holder side effects, hold generations and failure cleanup. Three changed modules parse and compile without execution. Controlled-copy tests, resource peak, original-data/native/physical acceptance remain OPEN; no replay or live/donor mutation.
Use existing NoMaintenanceHolder.acting inside the captured registry cut. Ordinary source writes now refuse before mutation, and the private target remains writable. Restore the original claim on every exit. Before/after source observations remain an additional fence. The declared target-only SelectedInputsProbe calls the complete selected operation before first include and through context/coordinator selection. Complete reader preflight refuses oversized groups; ordinary copies and backups remain unchanged. Exercise the decoded probe request and all four stores, donor-contained destination refusal and no-copy budget refusal.

The preceding122-case execution is114passed/8failed/rc1. Seven cases met the real free-space guard on /tmp; exactly8affected cases passed in2.89s on fresh owned /home basetemp after fixing the stopped-thread oracle against unregister. Those are separate retained epochs, not122/122. Five correction modules compiled without executing subjects. New claim-scoped controls and original-data/native/physical acceptance remain OPEN.
Agent-Comms-Unpublished: {"kind":"unpublished","predecessor":{"commit":"7da92df5e33ae1fa0cb1598cbf009c9a8824e327","repository":"openhcsdev/agent-comms"},"sources":[{"baseline":{"commit":"3872d91ae52792f2a7f61e17aa81b51c25557604","repository":"openhcsdev/agent-comms"},"candidate_tree":"f6e87cae9857c1f5454f9b9e67d3fe65472def93","heads":[{"head":"7a2b1f5c791953f40127f7ff71804445e06d5b54","pr":3829,"repo":"openhcsdev/agent-comms"}],"kind":"local_integration"},{"baseline":{"commit":"b67c97e5c3ad1eda5c06a464fdc578038d01e3e8","repository":"openhcsdev/formbridge"},"candidate_tree":"8632c131ec6c529cae78de44d86e191dbbbd844a","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"60138d533ef0758c5f093d9110ba9f5656f0934a","repository":"openhcsdev/metaclass-registry"},"candidate_tree":"3c11508a7bf34cfbe79964127305e056227b6b56","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"da87b77f22bd032bf7cd6d52630f684fa4a2b320","repository":"openhcsdev/textual"},"candidate_tree":"69923b8856c78a1053ca02d045f5b23e875a2c5b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"58c6ca55b09a250b872f8d9323cefad76b09aec9","repository":"openhcsdev/toad"},"candidate_tree":"aba05d441f89f32758f25638a46bf6c7815fde8b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"ba614bcb90b38c1f70789059a3c6aef8c017971b","repository":"openhcsdev/ui-theme"},"candidate_tree":"6a6cbe340cdd660e3d59cd086b15566d8836a0a2","heads":[],"kind":"merged_integration"}]}
Agent-Comms-Integration: {"carrier":{"head":"c9c7aacf7161f38eecf2350ddfbed6a02f210bb1","pr":3871,"repo":"openhcsdev/agent-comms"},"kind":"combined","sources":[{"baseline":{"commit":"3872d91ae52792f2a7f61e17aa81b51c25557604","repository":"openhcsdev/agent-comms"},"candidate_tree":"f6e87cae9857c1f5454f9b9e67d3fe65472def93","heads":[{"head":"7a2b1f5c791953f40127f7ff71804445e06d5b54","pr":3829,"repo":"openhcsdev/agent-comms"}],"kind":"local_integration"},{"baseline":{"commit":"b67c97e5c3ad1eda5c06a464fdc578038d01e3e8","repository":"openhcsdev/formbridge"},"candidate_tree":"8632c131ec6c529cae78de44d86e191dbbbd844a","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"60138d533ef0758c5f093d9110ba9f5656f0934a","repository":"openhcsdev/metaclass-registry"},"candidate_tree":"3c11508a7bf34cfbe79964127305e056227b6b56","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"da87b77f22bd032bf7cd6d52630f684fa4a2b320","repository":"openhcsdev/textual"},"candidate_tree":"69923b8856c78a1053ca02d045f5b23e875a2c5b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"58c6ca55b09a250b872f8d9323cefad76b09aec9","repository":"openhcsdev/toad"},"candidate_tree":"aba05d441f89f32758f25638a46bf6c7815fde8b","heads":[],"kind":"merged_integration"},{"baseline":{"commit":"ba614bcb90b38c1f70789059a3c6aef8c017971b","repository":"openhcsdev/ui-theme"},"candidate_tree":"6a6cbe340cdd660e3d59cd086b15566d8836a0a2","heads":[],"kind":"merged_integration"}]}
@trissim

trissim commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Closing this failed qualification-only carrier: the retained-input implementation is delivered by Core#3829, merged as 012ec8f and present in the installed runtime build record. The carrier branch, source-cut directories and failed publication/recovery evidence are retained. Continuing P1086 original-data and reader acceptance stays with pi-publication-carry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant