Repository navigation
Conversation
…ch/runtime-shell-nov1
…ch/runtime-shell-nov1
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-tools at 83e1c45, every finding: |
|
debt-src at 83e1c45, every finding: |
trissim
enabled auto-merge
November 2, 2026 03:11
Contributor
Author
|
Superseded by #3825, merged as 0d5afb1. Closing as superseded with Tristan's approval. #3825 carries the runtime identity and exact-input repairs this batch wrapped. Generated by Claude Code |
auto-merge was automatically disabled
November 2, 2026 16:19
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime identity, shell safety and the merged export runtime
Four integration commits; 19 files, +1184/-99 versus main2b89. Preserves the original3825/46fc and3847/33c2 histories, carries3825's363b cache correction, and pins merged Toad1400/d47f216e plus Textual218/7c62867. No retention or submission overhaul is included.
Runtime identity
Before: commits could masquerade as complete runtime identity, the mutable process title could become the image filename, and compiled external-model conversion could fall into an opaque schema path.
After: byte/file artifacts and the actual mapped image own interpreter observations; recorded and absent evidence remain distinct; the compiled model decoder owns reference-scoped schema and conversion together. Functional candidate wheels stay distinct from production-cache eligibility and borrowed dependencies. No fabricated ancestry, donor mutation, title-removal workaround or dropped native tool.
The real45be rehearsal exposed a missed consumer: cache matching demanded a recorded observation from installed2b89's older metadata. InterpreterBuild now owns False for absent evidence and RecordedInterpreterBuild owns actual equality. Runtime/proof admission still refuses missing or changed evidence; ineligibility is not a fabricated certificate.
Shell safety
The existing lexer owns logical continuations, native quote characters, heredocs, descriptors, assignments and fail-closed inspection. Bounded ShellText cursor reads replace six whole-source snapshots. Native shlex state remains an external alphabet. The final typing correction preserves native int-or-None reads and an equivalent short circuit; parser test bodies remain unchanged.
Export and native contract activation
The generated lock advances Toad03f32f to merged1400/d47f216e and Textual9a0501 to merged218/7c62867. UI transfers inherit the application's existing preparation lifetime; the actual exporter observer owns cancellation. Shared native Bordered reads retain real CSS/slot writers and required frozen PaintStyles snapshots—no placebo setters or second style store. Original sidebar/editor and both author histories survive the clean integration.
Actual qualification epochs
-45be: 115 tests and293subtests passed, exit0. Combined shell/wait/refusal/root/installer selection plus actual-image and external-model-schema regressions; no full suite or local NRA gate.
-45be: genuine candidate completion succeeded; supported rehearsal failed on absent interpreter evidence. Failure retained.
-ae6468c7b4: inspected363b correction carried; two predicate/strict-admission regressions passed in1.85s, exit0, using the genuine candidate interpreter and actual RuntimeStack probe.
-ae6468c7b4: rehearsal refused an uncommitted generated Textual lock before copying. Integration error retained, not called a carry failure or a pass.
-e2ebacf524: generated native/export lock committed; supported preparation/rehearsal passed, exit0, from the installer's private source snapshot under the real host TestLease and INT300. Pending carries and target schema rewrites are empty, so ExistingBusInstall.rehearsed correctly reports uncopied with zero copied bytes. This is not relabeled as a copied-root carry test; that historical qualification scope remains separate from this no-migration delivery.
The exact1400/218 author pair separately passed affected UI cases and the two real indexed-writer Cancel/app-close cases. Those results are not phone, original-history-root or performance certificates. Earlier wheel/worker/carry results retain their actual revisions.
Assumed: original and uncertain inputs remain untouched; borrowed runtimes stay read-only; application/physical evidence remains separate from source and preparation. Runtime carry qualification is not replaced by passing selected tests. The source branch remains clean during the supported rehearsal.