Repository navigation
Prepare the real native prompt for the audit settlement fixture - #3845
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 fixture, +3/-3; 16 original assertions and 6 with/raises controls unchanged
Follow-through from merged #3820 and the system-prompt delivery change. The current-main combined run collected163, with159 passing and4 setup failures. This repairs ONLY the audit-case setup failure; claude-ai owns the separate native-package fixture repairs.
Before → after
test_pi_question_settles_only_on_its_exact_successful_audit_writedeclares a real native session but omitted its existingnative_runtime_packagedependency. Its initial CompactionEnd now consults SystemPromptDelivery and failed before any settlement assertion becausestack/SYSTEM_PROMPT.md.reads.jsondid not exist.The case now requests the existing session-scoped native package fixture. That owner already qualifies the real package and runs DealPrompt.prepare, rendering the actual prompt and matching read manifest together. No handwritten manifest, production fallback, mocked gate or new fixture class is added. The old manual-read loop is deleted: the compiled system prompt already supplies those reads. One assertion checks the actual captured read set.
The exact-ID, foreign/malformed/short answers, transcript-only refusal, repeated refused-tool behavior, escalation and successful-write-only settlement assertions are unchanged. The synthetic transcript lines remain explicit negative UNIT controls, never model-acceptance evidence.
Source evidence, not a passing test claim
Assumed:
native_runtime_packageremains the existing real package/prompt preparation owner. Its actual compiler is used, not a pretend file to hush FileNotFoundError. #3820's configured running-turn proof remains independently accepted; idle-wake and production installation remain open.