Skip to content

Prepare the real native prompt for the audit settlement fixture - #3845

Merged
trissim merged 1 commit into
mainfrom
pi-pr-salvage-audit-fixture
Nov 1, 2026
Merged

trissim merged 1 commit into
mainfrom
pi-pr-salvage-audit-fixture

Conversation

@trissim

@trissim trissim commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

1 fixture, +3/-3; 16 original assertions and 6 with/raises controls unchanged

Follow-through from merged #3820 and the system-prompt delivery change. The current-main combined run collected163, with159 passing and4 setup failures. This repairs ONLY the audit-case setup failure; claude-ai owns the separate native-package fixture repairs.

Before → after

test_pi_question_settles_only_on_its_exact_successful_audit_write declares a real native session but omitted its existing native_runtime_package dependency. Its initial CompactionEnd now consults SystemPromptDelivery and failed before any settlement assertion because stack/SYSTEM_PROMPT.md.reads.json did not exist.

The case now requests the existing session-scoped native package fixture. That owner already qualifies the real package and runs DealPrompt.prepare, rendering the actual prompt and matching read manifest together. No handwritten manifest, production fallback, mocked gate or new fixture class is added. The old manual-read loop is deleted: the compiled system prompt already supplies those reads. One assertion checks the actual captured read set.

The exact-ID, foreign/malformed/short answers, transcript-only refusal, repeated refused-tool behavior, escalation and successful-write-only settlement assertions are unchanged. The synthetic transcript lines remain explicit negative UNIT controls, never model-acceptance evidence.

Source evidence, not a passing test claim

  • NRA parsed all1210 Core src/tests modules:70 related declaration/import/consumer sites, zero parse omissions. Relevant production/fixture owners read semantically. Dynamic alias resolution/runtime MRO are outside that syntactic evidence.
  • Targeted changed-module NRA reparse and compile passed; git diff --check passed.
  • AST comparison retains all16 original assertions and all6 with/raises controls, with one actual-read assertion added.
  • No pytest/native/model/application run in this correction. Integration owner owes this one affected case against current main, alongside the separate native-package correction, not a replay of the entire historical selection.

Assumed: native_runtime_package remains the existing real package/prompt preparation owner. Its actual compiler is used, not a pretend file to hush FileNotFoundError. #3820's configured running-turn proof remains independently accepted; idle-wake and production installation remain open.

The fixture declared a native session and forgot to pack the native package.

Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit ac83d60 into main Nov 1, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants