Skip to content

test(acp): share the protocol server fixture - #405

Open
BunsDev wants to merge 1 commit into
mainfrom
test/acp-shared-fixture-current-main
Open

BunsDev wants to merge 1 commit into
mainfrom
test/acp-shared-fixture-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Share one ACP test-server constructor across diagnostic, dispatch, and reader fixtures.
  • Remove 59 lines while preserving the test cases and assertions.

Context

  • Related user request: Goal 3 manifest position 134 (logical unit 138), ported onto main 87239e7.
  • Scope: test support only; this branch is independent of the turn-permission PR fix(acp): bind permission requests to each turn #404.
  • Non-goals: production ACP changes, authentication or provider startup, dependency changes, and releases. Merge remains held until v0.9.0 exists.

Changes

  • Move three identical constructors into test_support::server, behind cfg(test).
  • Replace local constructors with imports. Every call still constructs its own runtime and client; no shared mutable singleton is introduced.
  • Leave the historical source's already-landed production prerequisites out of this port.

Validation

Rust commands ran from src-rust/ with serialized Cargo, an isolated Cargo home, and a shared target.

  • Before and after cargo test -p claurst-acp --locked: 47 passed, 0 failed, 0 ignored; doctests passed.
  • Structural reduction: three identical constructors before, one after. The shared constructor matches each original exactly apart from pub(crate) visibility. Remaining test code and assertions compare unchanged; production code is unchanged.
  • Independent spec and quality review: no blocking findings.
  • git diff --check: passed.
  • cargo fmt --all and cargo fmt --all -- --check: passed.
  • cargo check --workspace --all-targets --locked: passed.
  • cargo clippy --workspace --all-targets --locked -- -D warnings: passed.
  • cargo test --workspace --locked: 2760 passed, 0 failed, 52 ignored across 110 outer suites, counting nested worker output once.
  • N/A: terminal suite, as TUI, input, and production code are unchanged.

PR Readiness

  • Diff is limited to five test-support files.
  • No manifest, lockfile, or generated file changes.
  • User-facing docs/help changes are not needed for a test-only extraction.
  • No real credentials or private captured data are included.
  • No new runtime behavior is claimed; authentication and real provider integration are outside these fixtures.

Reuse the identical test-server constructor across diagnostic, dispatch, and reader fixtures without changing their assertions or production behavior.

Coven-Harness: Codex / GPT-6
@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 18, 2026 2:30pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — a8a667ac Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant