Skip to content

fix(acp): omit inbound payloads from connection warnings - #400

Merged
BunsDev merged 1 commit into
mainfrom
fix/acp-log-payload-current-main
Oct 18, 2026
Merged

BunsDev merged 1 commit into
mainfrom
fix/acp-log-payload-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace ACP connection warnings that echoed malformed JSON-RPC input or unknown response IDs with shape, type, and byte-count metadata.
  • Keep request routing and parse-error responses unchanged.

Context

  • Related request: Goal 3 manifest position 130 (surface-acp-log-payload).
  • Scope: claurst-acp connection logging and three captured-log regressions.
  • Non-goals: server dispatch diagnostics (position 131) and broader ACP log privacy.

Changes

  • Unknown response IDs now log ID kind and byte length, without the ID value.
  • Unrecognized messages now log JSON type, byte length, and envelope presence bits, without the input line.
  • Tests cover payload canaries, Unicode and numeric IDs, normal delivery, and parse-error wire output.

Validation

  • Baseline on current main: cargo test -p claurst-acp --lib log_payload_tests --locked — 2 leak regressions failed, 1 control passed.
  • Focused after change: same command — 3 passed.
  • git diff --check — passed.
  • cargo fmt --all and cargo fmt --all -- --check — passed.
  • cargo check --workspace --all-targets --locked — passed.
  • cargo clippy --workspace --all-targets --locked -- -D warnings — passed.
  • cargo test --workspace --locked -- --test-threads=1 — passed.
  • Independent spec and quality review — no blocking findings.
  • TUI runner — N/A; no TUI or input code changed.

PR Readiness

  • Diff is limited to src-rust/crates/acp/src/connection.rs.
  • Generated files were not edited by hand.
  • No user-facing docs/help change is needed.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risk: other ACP diagnostic paths are outside this unit and tracked separately.

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 18, 2026 12:06pm UTC

Request Review

@BunsDev
BunsDev merged commit abb77d1 into main Oct 18, 2026
9 checks passed
@BunsDev

BunsDev commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Reviewed 63de7669976c7b219245163bebc5d97bcf4e7f45; no blocking findings. Full connection implementation and actual diff reviewed. The two changed warning sites emit fixed type labels, UTF-8 byte counts and presence bits; pending response delivery, routing, and parse-error wire output remain unchanged. Captured-log tests cover payload canaries, ID forms and behavior controls.

Whitespace and all eight hosted checks passed on this head. No duplicate local Cargo build was run; focused baseline/after results remain author evidence. Composition with current main 2bea1c3 is clean, with connection.rs unchanged on main since the reviewed base. The scope is these warning sites, not blanket ACP log privacy.

This branch was successfully deployed

1 active deployment
Preview — 63de7669 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant