Feature/postgres support - #2083
Open
Stephan-Kok wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL support
This PR is a follow-up to [PR #2082](#2082).
In this PR, we remove the
sso_provider_roles_eb5table and introduce PostgreSQL support.PostgreSQL documentation
I have added a document with additional information about how to use the PostgreSQL database and how the integration works:
https://github.com/OpenConext/OpenConext-engineblock/blob/feature/postgres_support/postgres_support.md
The document also describes some additional changes that are required in the EngineBlock container and OpenConext-devconf to support PostgreSQL natively.
Additionally, I think we should discuss whether we can add a CI/CD test using a PostgreSQL database to ensure that PostgreSQL support continues to work going forward.
Consent
One aspect I would like you to look into more deeply is the Consent functionality.
We currently do not use the Consent feature, but PostgreSQL does not support the SQL value
0000-00-00 00:00:00, which is used in a hardcoded SQL query.I have attempted to address this by replacing it with the epoch date
1970-01-01 00:00:00. Please seeDbalConsentRepository.phpin this PR.During my initial investigation, it appeared that
deleted_atmay have been incorrectly configured as a primary key, which is the reason this workaround seems to be necessary.If this is not intentional, it would be preferable to remove this requirement and solve the underlying issue rather than keeping my current workaround. Please take a closer look at this part of the PR and let me know if the
deleted_atprimary key is intentional.