Repository navigation
fix(network): Silver startup/liveness ask its API; arch check reads the node; warn when sync restarts the EL - #904
Merged
Merged
Conversation
…he node; warn when sync restarts the EL - Silver startup and liveness probes are httpGet /eth/v1/node/version (as ethpandaops/ethereum-helm-charts#505), so a boot stalled before the first engine-API exchange restarts after 30 min, and a hung API after 6. - Silver v0.1.0-alpha.13. - The amd64-only check reads the cluster nodes' kubernetes.io/arch label when the cluster answers, falling back to the CLI's GOARCH. - network sync warns when it will also restart the EL: deployments made before per-network memory requests get them on their next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the rc1 runs on the dev box (Hoodi and mainnet Silver).
GET /eth/v1/node/version, matching fix(silver): HTTP probes, info logs, amd64 node selector; bump to alpha.12 ethpandaops/ethereum-helm-charts#505. Until then they weretcpSocketprobes, which pass as long as the port accepts connections./eth/v1/node/health, from fix(network): Silver logs at info and is ready only when its beacon API answers #901).v0.1.0-alpha.13("clustering fixes", clustering fixes gattaca-com/silver#470). The version fix, Report the crate version in the agent version gattaca-com/silver#473, merged after alpha.13 was cut, so it lands in the next alpha.network installandnetwork syncused to compare Silver's amd64-only image against the CLI'sruntime.GOARCH.kubernetes.io/archlabel, with a 5 s request timeout. If the cluster doesn't answer, they fall back toruntime.GOARCH.network syncwarns when it will also restart the EL.ethereum-executionStatefulSet. If it has no memory request (and the node isn't stopped), sync prints:This sync also restarts reth (the execution client) once: ….