Repository navigation
Conversation
feerecipient sign adopts the gas limit and timestamp of an in-progress registration so partial signatures aggregate. It now refuses to adopt one with gas limit 0, or with a timestamp more than 5 minutes in the future unless the operator confirms it with the same --timestamp. It also refuses to start a new registration when no gas limit can be determined. category: bug ticket: none
|
OisinKyne
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4821 +/- ##
==========================================
+ Coverage 67.72% 67.74% +0.01%
==========================================
Files 255 255
Lines 33711 33726 +15
==========================================
+ Hits 22832 22848 +16
+ Misses 10878 10877 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing until we re-look at fee recipient signing in Gloas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feerecipient signadopts the gas limit and timestamp of an in-progress registration so that partial signatures aggregate. It now refuses to adopt one with gas limit 0, or with a timestamp more than 5 minutes in the future unless the operator confirms it with the same--timestamp. It also refuses to start a new registration when no gas limit can be determined.category: bug
ticket: none