Repository navigation
Conversation
create cluster without a definition file skipped withdrawal address validation and the insecure-keys-on-mainnet check, and add-validators and create dkg fee recipients were never validated, so a zero or mistyped address on mainnet produced valid deposits. All create/edit paths now share one rule: 0x + 40 hex, all lower or all upper case accepted, mixed case must match EIP-55, zero address forbidden on mainnet/gnosis, stored checksummed. feerecipient sign refuses gas limit 0 and adopting an in-progress registration timestamped more than 5 minutes ahead unless --timestamp confirms it. exit sign with both --validator-public-key and --validator-index checks the index belongs to the pubkey when the beacon node knows it.
Zero withdrawal and fee recipient addresses are legitimate when the generated deposit data is never used, e.g. splitting existing keys of active validators, or clusters that deposit through their own contracts (EtherFi's mainnet clusters use the zero withdrawal address). Keep the existing zero withdrawal address errors in create dkg and create cluster --definition-file, and only warn on the paths this branch newly validates: create cluster from flags, add-validators and fee recipients.
…sses Points feerecipient sign and deposit.WithdrawalCredsFromAddrOrCreds at the shared eth2util.ValidateChecksumAddress, so the EIP-55 rule lives in one place. This also fixes feerecipient sign rejecting all-uppercase addresses. category: refactor ticket: none
Since EIP-7044 the voluntary exit domain is fixed to the Capella fork version, so exit sign now computes it locally for known networks from a new genesis validators root network field. With both --validator-public-key and --validator-index, --beacon-node-endpoints is optional; when a beacon node is configured, the index is still cross-checked against the public key. Custom testnets and --all still need a beacon node. category: feature ticket: #3104
github-actions
Bot
added
the
branch-invalid
|
KaloyanTanev
previously approved these changes
Nov 4, 2026
KaloyanTanev
left a comment
KaloyanTanev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, apart from unit tests failing
obol-bulldozer
Bot
dismissed
KaloyanTanev’s stale review
November 4, 2026 17:17
The base branch was changed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
==========================================
+ Coverage 67.72% 67.76% +0.03%
==========================================
Files 255 255
Lines 33711 33773 +62
==========================================
+ Hits 22832 22886 +54
- Misses 10878 10886 +8
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since EIP-7044 the voluntary exit domain is fixed to the Capella fork version.
exit signnow computes it locally for known networks, using a newGenesisValidatorsRootHexnetwork field taken from the public/eth/v1/beacon/genesis. With both--validator-public-keyand--validator-index,--beacon-node-endpointsbecomes optional. If a beacon node is configured, the index is cross-checked against the pubkey: a mismatch is an error, and an unknown index or an unreachable BN is a warning. Custom testnets and--allstill need a beacon node.exit broadcastis unchanged.Tests:
ForkDatacomputation for every network, and the mainnet value (0x04000000bba4da96…676640) is pinned;exit signon Hoodi with no beacon node is verified by the mock Obol API using a beacon node's domain.category: feature
ticket: #3104