Repository navigation
Conversation
github-actions
Bot
added
the
branch-invalid
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## oisin/strict-lock-verification #4819 +/- ##
==================================================================
+ Coverage 67.81% 67.89% +0.07%
==================================================================
Files 255 255
Lines 33808 33914 +106
==================================================================
+ Hits 22928 23026 +98
- Misses 10879 10887 +8
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KaloyanTanev
reviewed
Nov 4, 2026
Adds Lock.VerifyContents: deposit data must match the distributed validator pubkey, the definition withdrawal credentials and deposit amounts, and carry a valid BLS signature; builder registrations must match the distributed validator pubkey and the definition fee recipient; addresses must be valid (Definition.VerifyAddresses). Only enforced where charon creates a lock from scratch (create cluster and a fresh DKG), plus address checks on DKG definitions. Loading an existing lock (run, exits, other commands), the edit protocols and appending validators don't check contents, so startup isn't slowed by BLS verifying every deposit signature. category: feature ticket: none
OisinKyne
force-pushed
the
oisin/lock-content-checks
branch
from
November 4, 2026 17:13
3081c4d to
09a67de
Compare
|
KaloyanTanev
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Lock.VerifyContents. It checks that deposit data matches the DV pubkey, the definition withdrawal credentials and the deposit amounts, and has a valid BLS signature. It checks that builder registrations match the DV pubkey and the definition fee recipient, and that addresses are valid (Definition.VerifyAddresses).create cluster, fresh DKG) and on DKG definitions (bypassable with--no-verify).run, exits, deposit and feerecipient commands), so a running node never fails to restart. Also warn only in the edit protocols and DKG append mode, since their output inherits the old lock's contents.Make it an error in a later release.
category: feature
ticket: none