[19.0][IMP] queue_job: Implement on fail hook - #955
Merged
Conversation
Contributor
This was referenced Jul 24, 2026
Closed
Contributor
|
Just for the record, there were 2 other attempts to manage this
Your approach seem cleaner tho. |
simahawk
reviewed
Jul 27, 2026
florentx
reviewed
Jul 27, 2026
florentx
left a comment
florentx
left a comment
Contributor
There was a problem hiding this comment.
CI fails on test_queue_job add-on.
Contributor
|
IMO the test failure is correct because it runs in a temporary env that is not rolled back. |
Author
amh-mw
suggested changes
Jul 29, 2026
guewen
reviewed
Aug 10, 2026
grindtildeath
force-pushed
the
19.0-imp-queue_job_on_fail_hook
branch
2 times, most recently
from
August 13, 2026 19:39
5b6143c to
6651362
Compare
amh-mw
approved these changes
Aug 17, 2026
Ricardoalso
force-pushed
the
19.0-imp-queue_job_on_fail_hook
branch
from
August 25, 2026 06:20
ae92e14 to
10aea19
Compare
Allows to execute a model function when the job fails and will not be retried. [REF] queue_job: Move on fail definition to job function Rename on_fail_hook to on_fail
simahawk
force-pushed
the
19.0-imp-queue_job_on_fail_hook
branch
from
August 27, 2026 12:44
10aea19 to
ad4d223
Compare
Contributor
|
Rebased and squashed. @guewen good for you? |
Member
|
/ocabot merge minor Yes, thanks! |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at bec45a9. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to execute a model function when the job fails and will not be retried.