[17.0]edi_oca: configurable per-stage related-record notifications + form cleanup - #317
Open
GuillemCForgeFlow wants to merge 2 commits into
Open
Conversation
Contributor
SilvioC2C
reviewed
Jul 9, 2026
Comment on lines
-42
to
-65
| <group name="config"> | ||
| <field name="exchange_filename_pattern" /> | ||
| <field name="exchange_filename_sequence_id" /> | ||
| <field name="exchange_file_ext" /> | ||
| <field name="exchange_file_auto_generate" /> | ||
| <field name="ack_type_id" /> | ||
| <field name="ack_for_type_ids" widget="many2many_tags" /> | ||
| <field name="partner_ids" widget="many2many_tags" /> | ||
| <field name="job_channel_id" /> | ||
| <field name="quick_exec" /> | ||
| <field name="encoding" /> | ||
| <field | ||
| name="encoding_out_error_handler" | ||
| invisible="direction == 'input'" | ||
| /> | ||
| <field | ||
| name="encoding_in_error_handler" | ||
| invisible="direction == 'output'" | ||
| /> | ||
| <field | ||
| name="allow_empty_files_on_receive" | ||
| invisible="direction == 'output'" | ||
| /> | ||
| </group> |
Contributor
There was a problem hiding this comment.
Please don't do this: this architecture might be inherited and customized by third-party modules, and this change might break the view's inheritance mechanism (even though I personally agree a page in the notebook yields to a better UX).
Author
There was a problem hiding this comment.
I see, thanks for pointing out. what I've done now is still keep the name="config" attribute on the main group in the view. I understand there's still a chance that will can break current installations. do you think we should perhaps note this to be done in the next migration?
Move the exchange-type configuration fields out of the header and into a dedicated 'Configuration' notebook page, grouped by nature (File, Automation, Acknowledgement, Scope). The header keeps only the base identity params (backend, backend type, code, direction).
Add per-type toggles (notify_rel_rec_on_generate/send/process/receive, default True) on edi.exchange.type controlling whether a chatter note is posted on the related record for each exchange stage. The gate lives in the single funnel edi.exchange.record._notify_related_record, which now takes the stage action and consults edi.exchange.type._notify_related_on; generate/send/receive thread it via notify_action_complete, process via _notify_done/_notify_error. Defaults preserve the previous always-notify behavior.
GuillemCForgeFlow
force-pushed
the
17.0-imp-reorg_exch_type_ui_toggle_notify
branch
from
July 10, 2026 07:36
47cb50b to
0ce38b4
Compare
Author
|
@simahawk any thoughts on this? |
simahawk
requested changes
Aug 24, 2026
simahawk
left a comment
simahawk
left a comment
Contributor
There was a problem hiding this comment.
@GuillemCForgeFlow Thanks for your contrib!
I don't think this should stay core.
I would add a new module or add this to edi_notification_oca.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How
Tests
Adds coverage in test_backend_output.py: with notify_rel_rec_on_generate = False, generate posts no note while send still does; default behavior unchanged.
cc @ForgeFlow