Skip to content

Feature/multi audio - #144

Open
zabaznov-roman wants to merge 5 commits into
Notely-Voice:mainfrom
zabaznov-roman:feature/multi-audio
Open

Feature/multi audio#144
zabaznov-roman wants to merge 5 commits into
Notely-Voice:mainfrom
zabaznov-roman:feature/multi-audio

Conversation

@zabaznov-roman

Copy link
Copy Markdown

No description provided.

@tosinonikute

Copy link
Copy Markdown
Member

@zabaznov-roman Thanks, I appreciate the PR and I'll give this a test first & then do some reviews :-)

Also in future its good if you have a screenshot or video that helps to quickly see how it works before running it.

@tosinonikute
tosinonikute self-requested a review August 21, 2026 12:40
@tosinonikute

Copy link
Copy Markdown
Member

Hi @zabaznov-roman While testing, I found some issues.

  1. Audio seek affects all recordings, not just the one being seeked

Root cause: Single shared audio player state for multiple recordings. AudioPlayerViewModel uses one _uiState to manage playback for all recordings, so seeking any single audio updates the shared state and ends up seeking every audio instance at once.

  1. Delete icon overlaps the audio duration text & slide to delete affected

Root cause: RecordingItem uses a Box layout with the delete button aligned to TopEnd, which causes it to overlap the duration text instead of being positioned separately.

  1. Transcription always transcribes the first audio

Root cause: When navigating to the transcription screen, the code always references the legacy recording.recordingPath instead of asking which one it is to transcribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants