Repository navigation
fix(chat): chat window without Node, links in the browser - #249
Closed
edospadoni wants to merge 1 commit into
Closed
edospadoni wants to merge 1 commit into
edospadoni wants to merge 1 commit into
Conversation
The chat window shows what colleagues and guests send. It ran with nodeIntegration and without context isolation, so a script in that page would have had the whole computer. Now it has only the preload's bridge; links open in the system browser and the page cannot navigate away from the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat island window shows messages, images and links sent by colleagues and, with the external guests, by people outside the company. It was created with `nodeIntegration: true` and `contextIsolation: false`: any script that ever ran in that page would have had Node, that is the user's computer.
Now the chat window:
The shared logger and env helper no longer assume `process` exists in the page.
The other windows are unchanged. Next steps, separate: `sandbox: true` for this window (the preload uses `os`, so it needs a small rework) and an Electron upgrade (28.x is out of support).
Draft: typecheck and build pass; it needs a run of NethLink to check the chat window (open, send, attachments, links, call buttons, move to CTI).
Found in a security review of the chat.
Refs NethServer/dev#7648