More modularization - #2173
Open
ispeters wants to merge 10 commits into
Open
Conversation
This diff adds to the modules build all of the currently-broken tests in `test.stdexec` that break for reasons related to `__apply`.
It turns out pack indexing is broken in Clang prior to version 24 when building with modules llvm/llvm-project#214780. This diff disables pack indexing for Clang builds prior to version 24 when modules are enabled, which allows me to add several more tests to the modules build. We're up to 2323 assertions in 385 test cases in `test.stdexec`.
This diff enables more tests in `test.stdexec`; we're up to 2609 assertions in 489 test cases.
We're up to 3011 assertions in 568 test cases in `test.stdexec`.
Some recent commits added more types that need exporting; this diff exports those types.
This diff forces the parallel scheduler implementation inline in the modular build, which means the final test can now be included in the modular build of `test.stdexec`.
Collaborator
|
/ok to test b144492 |
This diff removes from the modular build those test files that cause Clang 22.1.6 in the rapidsai container to ICE. This leaves `test.stdexec` reporting 3135 assertions in 483 test cases.
`test_let_error.cpp` ICEd in CI; reproing with it excluded in the same container running in a VM on my Mac led to a new ICE in `test_parallel_scheduler.cpp` so I've removed that one, too.
ispeters
force-pushed
the
more-modularization
branch
from
August 10, 2026 05:59
b144492 to
7265c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds to the modular build the rest of the tests in
test.stdexecthat don't cause Clang 22.1.6 to ICE in the rapidsai container that CI uses to run the modularized tests. I'm working on understanding why the excluded tests cause the ICE.This PR leaves the modular build of
test.stdexecreporting 3135 assertions in 483 test cases.