Skip to content

Preserve error references in materialize - #2161

Merged
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/materialize-error-reference
Aug 10, 2026
Merged

Preserve error references in materialize#2161
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/materialize-error-reference

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • forward materialize errors without copying them
  • add a regression test for a non-copyable error delivered by lvalue reference

Why

materialize advertises set_error_t(error_type&) as set_value_t(set_error_t, error_type&), but its receiver took errors by value. That can require a copy and changes an lvalue into an rvalue. This forwards the error so the runtime behavior matches the completion signature.

Testing

  • cmake --build build --target test.exec -j 8
  • ./build/test/exec/test.exec '[materialize]'

@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@fallintoplace
fallintoplace marked this pull request as ready for review August 8, 2026 15:32
@fallintoplace
fallintoplace marked this pull request as draft August 8, 2026 15:33
@fallintoplace
fallintoplace marked this pull request as ready for review August 8, 2026 15:34
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 86f5857

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test dfe4351

@ericniebler
ericniebler merged commit f4d9cdf into NVIDIA:main Aug 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants