refactor(compute): unify gateway restart reconciliation - #2743
Open
drew wants to merge 1 commit into
Open
Conversation
Remove the Docker-specific gateway shutdown cleanup and reconcile persisted running intent through ComputeDriver::StartSandbox for Docker, Podman, and VM drivers. Explicitly stopped sandboxes remain stopped. Closes #2417 Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 14, 2026 01:29
6 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-2743.docs.buildwithfern.com/openshell |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the Docker-only gateway shutdown/startup lifecycle hooks. Gateway shutdown now leaves durable local compute alone, while startup reconciles persisted running intent through the shared idempotent
ComputeDriver::StartSandboxRPC for Docker, Podman, and VM drivers.Related Issue
Part of #2417
Changes
stop_managed_containers_on_shutdownTesting
mise run pre-commitpassesCommands run:
cargo test -q -p openshell-server start_persisted_sandboxes --lib— passedcargo test --no-run --features e2e-docker,e2e-podman,e2e-vmine2e/rust— passedOPENSHELL_E2E_DOCKER_TEST=gateway_start mise run e2e:docker— passedOPENSHELL_E2E_PODMAN_TEST=podman_gateway_start mise run e2e:podman— not run; host has no Podman CLImise run e2e:vm— blocked twice by the existing VM smoke test before the restart test (supervisor/SSH relay readiness failure)mise run test— all completed suites passed except the unrelatedgateway_completer_returns_empty_when_no_config, which reproduces in isolation because this host has registered gateway configChecklist