Skip to content

merp #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThatCuteOne merged 2 commits into from
Oct 31, 2026
Merged

merp #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e12d578
test
Oct 31, 2026
f644a18
1f89a-2026.10.31-11.36.17-0400
Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/java/dev/intensed/fallback/api/RandomDialogAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,14 @@ public static int execute(CommandSourceStack source, int from, int to, String pr
objective = scoreboard.addObjective(OBJECTIVE_NAME, ObjectiveCriteria.DUMMY, Component.literal("Fallback Dialogs"), ObjectiveCriteria.RenderType.INTEGER, false, null);
}
ArrayList<Integer> available = new ArrayList<Integer>();
for (int number = from; number <= to; ++number) {
for(int number=from;number<=to;++number){
int score;
if (blocked.contains(number) || (score = scoreboard.getOrCreatePlayerScore(ScoreHolder.forNameOnly((scoreName = RandomDialogAPI.getScoreName(prefix, number))), objective).get()) != 0) continue;
if(blocked.contains(number))continue;
scoreName=RandomDialogAPI.getScoreName(prefix,number);
if(scoreName==null){continue;} // you can put smth else here if you want to handle null differently; this exists cuz i noticed your code would just have a heart attack and explode if scoreName was null so i added this to prevent that ^w^
ScoreHolder holder=ScoreHolder.forNameOnly(scoreName); //also i expanded your giant unreadable line into multiple lines for better readabilnessility
score=scoreboard.getOrCreatePlayerScore(holder,objective).get();
if(score!=0)continue;
available.add(number);
}
if (available.isEmpty()) {
Expand Down