Repository navigation
State the columns of the composite types of another extension a SQL function returns - #206
Merged
estebanzimanyi merged 1 commit intoOct 25, 2026
Conversation
…unction returns meta/sql-columns.json states under composites the members of a composite type another extension creates, which the SQL the catalog reads does not: PostGIS's geomval (geom geometry, val double precision), created by postgis_raster, which MobilityDB requires when built with RASTER. sql_statements reads them through declared_composites beside the composites the SQL creates, so dumpAsPolygons(raster, integer, boolean) RETURNS SETOF geomval states its two columns, and a rows statement feeds them from the geom and the val of each GeomVal the function returns, as the rows of valueCount read the fields of each ValueCount. summarystats, the other PostGIS composite MobilityDB returns, is one value a binding reads from its structure, and stays without columns. Measured over MobilityDB master 1a7a1a0e11: the catalog differs from master's in raster_dump_as_polygons alone, whose signature states its columns. Over that catalog the JVM generators of JMEOS main answer the same surfaces as over master's, and refuse dumpAsPolygons as setret:column/return:geometry where they refused it as setret:column/return:geomval, and MobilityDuck main's generator writes the same files. tests/test_sqlfn_rows.py reads the declared members of geomval for a function whose SQL creates none, reads the composites by type, and refuses a member stated without a type; the suite passes, 589 tests and none skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta/sql-columns.json states under composites the members of a composite type another extension creates, which the SQL the catalog reads does not: PostGIS's geomval (geom geometry, val double precision), created by postgis_raster, which MobilityDB requires when built with RASTER. sql_statements reads them through declared_composites beside the composites the SQL creates, so dumpAsPolygons(raster, integer, boolean) RETURNS SETOF geomval states its two columns, and a rows statement feeds them from the geom and the val of each GeomVal the function returns, as the rows of valueCount read the fields of each ValueCount. summarystats, the other PostGIS composite MobilityDB returns, is one value a binding reads from its structure, and stays without columns.
Measured over MobilityDB master 1a7a1a0e11: the catalog differs from master's in raster_dump_as_polygons alone, whose signature states its columns. Over that catalog the JVM generators of JMEOS main answer the same surfaces as over master's, and refuse dumpAsPolygons as setret:column/return:geometry where they refused it as setret:column/return:geomval, and MobilityDuck main's generator writes the same files. tests/test_sqlfn_rows.py reads the declared members of geomval for a function whose SQL creates none, reads the composites by type, and refuses a member stated without a type; the suite passes, 589 tests and none skipped.