Repository navigation
Name no GEOS type or header in the generated bindings - #32
Merged
Merged
Conversation
The public MEOS headers expose H3 as the one dependency whose header a consumer compiles against: no header includes a GEOS or GSL header, and no catalog function takes or returns a GEOSContextHandle_t. The generator therefore lists no GEOS type among the opaque types it leaves unwrapped, and the cgo preamble names H3 alone. Measured: against the libmeos of MobilityDB a23e01a60b, the regenerated packages differ from main only in that preamble comment, keeping 3994 flat wrappers and 1435 methods; the functions and types packages build, the portable-parity test and the gomeos examples pass. Why: MEOS answers without GEOS, and a binding states the dependencies the library has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public MEOS headers expose H3 as the one dependency whose header a
consumer compiles against: no header includes a GEOS or GSL header, and no
catalog function takes or returns a GEOSContextHandle_t. The generator
therefore lists no GEOS type among the opaque types it leaves unwrapped, and
the cgo preamble names H3 alone.
Measured: against the libmeos of MobilityDB a23e01a60b, the regenerated
packages differ from main only in that preamble comment, keeping 3994 flat
wrappers and 1435 methods; the functions and types packages build, the
portable-parity test and the gomeos examples pass.
Why: MEOS answers without GEOS, and a binding states the dependencies the
library has.