Skip to content

Remove from list: a repository header's menu and Ctrl Shift Backspace in the switcher - #2

Merged
Method-es merged 2 commits into
mainfrom
merge/remove-known-repo
Oct 28, 2026
Merged

Method-es merged 2 commits into
mainfrom
merge/remove-known-repo

Conversation

@Method-es

Copy link
Copy Markdown
Owner

Merges feat/remove-known-repo into this fork's main, the build used locally. The feature branch itself is based on kylekz/diff main, for its own upstream PR.

This merge resolves the overlap with the branch picker (#1): both add to the switcher's automation state, Esc and its module docs, the DESIGN §4.1 paragraph and the e2e README. The branch picker's header has no menu, and Ctrl Shift Backspace does nothing in it (asserted in the_branch_picker_opens_a_stacked_branch_against_its_base).

Checked on the merge: clippy clean in all three shapes, cargo test --workspace passes, and switcher_branches and switcher_remove_repo pass.

Keaton Johnstone added 2 commits October 28, 2026 14:31
… in the switcher

A right-click on a repository's header in the switcher, or its ⋯ under the pointer,
opens a menu with Remove from list; Ctrl Shift Backspace does the same for the selected
row's repository, from the filter field too. The repository leaves the switcher and
known_repos.json (Reviews::remove_repo: its row and any refresh go), nothing in it
changing, and the selection moves to the next repository's first row. The open review's
repository can't be removed: its item is disabled ("Its review is open") and the key
does nothing. Esc closes the menu first. DESIGN §4.1 and §5, PLAN §11; state.switcher
menu, switcher/repo/<repo>/more and switcher/menu/remove; switcher_remove_repo.
# Conflicts:
#	crates/dv/src/automation/state.rs
#	crates/dv/src/automation/tests.rs
#	crates/dv_ui/src/switcher/items.rs
#	crates/dv_ui/src/switcher/mod.rs
#	crates/dv_ui/src/switcher/tests.rs
#	docs/DESIGN.md
#	tests/e2e/README.md
@Method-es
Method-es merged commit 74216e0 into main Oct 28, 2026
Method-es pushed a commit that referenced this pull request Oct 29, 2026
Remove from list: a repository header's menu and Ctrl Shift Backspace in the switcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant