Add arm64 runtime identifiers to Maple2.File.Verify - #80
Conversation
MS2Verify is published self-contained, so it only runs on the CPU architecture it was published for. The RuntimeIdentifiers list held win-x64, linux-x64 and osx-x64 only, so an aarch64 machine had no supported way to build it and could not run the archive verification step that LithMS2-XML build.sh performs after every MS2Create call. Adds linux-arm64 and osx-arm64. No source change is needed, the project already builds and runs on both.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe verification project now includes ChangesRuntime target support
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized project configuration change adds arm64 publishing support without changing application logic; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MS2Verify is published as a self-contained binary, so it only runs on the CPU architecture it was published for. The
RuntimeIdentifierslist namedwin-x64,linux-x64andosx-x64only. That leaves an aarch64 machine with no supported way to build it, and MS2Verify is whatLithMS2-XML/build.shruns on every archive after MS2Create writes it. An arm64 developer machine could not run that verification step at all.Files
Maple2.File.Verify/Maple2.File.Verify.csproj— addslinux-arm64andosx-arm64toRuntimeIdentifiers. No source change was needed. The project already compiles and runs on both, the RID list was just never extended.Verification
Published from this branch on an aarch64 Ubuntu 22.04 box with the .NET 10 SDK building the
net8.0target:All four RIDs I tested succeed, and
filereports the expected format for each:linux-arm64gives an aarch64 ELF,linux-x64gives an x86-64 ELF, andosx-arm64gives a Mach-O arm64 executable. The pre-existing nullable-reference warnings inMaple2.File.IOappear on every RID and are unchanged by this PR.The
linux-arm64binary verified a real archive natively:I did NOT test
win-x64orosx-x64, and I have not run this on macOS or Windows hardware. Neither RID is modified by this change. I also did NOT rundotnet test, which needsMS2_DATA_FOLDERpointing at extracted game data that is not on this machine.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit