Repository navigation
chore(deps): adopt dialogs 8 with isolated native viewer - #9301
Open
dependabot[bot] wants to merge 8 commits into
Open
dependabot[bot] wants to merge 8 commits into
dependabot[bot] wants to merge 8 commits into
Conversation
Bumps [@nextcloud/dialogs](https://github.com/nextcloud-libraries/nextcloud-dialogs) from 7.5.0 to 8.0.0. - [Release notes](https://github.com/nextcloud-libraries/nextcloud-dialogs/releases) - [Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-dialogs@v7.5.0...v8.0.0) --- updated-dependencies: - dependency-name: "@nextcloud/dialogs" dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate LibreSign's own notifications and PDF file picker to
@nextcloud/dialogs8.0.0, using the official package name without npm aliases, peer overrides, or forced installation.Native Viewer compatibility
The native
@nextcloud/viewerand its Image Editor still require dialogs 7 as a peer dependency. The Viewer is essential to LibreSign's signed-document preview, including the protection that prevents a signed UUID PDF from exposing the owner's original file ID.To preserve that public Viewer API and keep each package's declared peer contract intact:
src/viewer/contains a minimal, private installation boundary for the existing Viewer and its dialogs 7 peer, with its own lockfile and a public-API re-export. The rootpostinstallinstalls this lockfile reproducibly.getViewer(),getHandlers(), andcanView(), with existing signed-UUID access safeguards unchanged.No upstream package files were modified. No external pull requests, issues, or comments were created.
Visual behavior
Dialogs 8 replaces Toastify-based notifications with accessible Vue toasts. Success, warning, and error notifications now appear at the bottom-start corner, with close buttons and appropriate accessible roles. The new CSS is imported by dialogs itself; LibreSign does not use the removed
style.cssentry point.Browser capture of the real dialogs 8 toast components in an isolated preview. The surrounding page is a test harness, not a screenshot of the production LibreSign app:
The screenshot is attached to this PR description; no screenshots or temporary test pages are versioned.
Verification
npm ci, including the native Viewer's nestednpm ci: passed.npm ls: passed with no peer conflicts, no aliases and no overrides.npm run ts:check,npm run lint,npm run stylelint,npm run build: passed locally.npm run test: 3,549 tests passed across 273 files.GitHub CI on the latest commit remains the authoritative merge gate. No merge was performed.