Repository navigation
fix: fresh Jellyfin 12 admin setup (v1.2.3) - #9
Merged
Merged
Conversation
Jellyfin 12 creates the default first user (root) on GET /Startup/User instead of POST. The previous skip-if-a-user-exists check therefore left root without a password and AuthenticateByName returned 401. Always POST Startup/User to rename the first user and set the password; tolerate 403 when a previous attempt already set one. v1.2.3.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the fresh-install failure in v1.2.2: Jellyfin 12 creates the default first user (
root) onGET /Startup/User, not on the POST. v1.2.2 skipped the POST when any user existed, leavingrootwithout a password, soAuthenticateByNamereturned 401.Now
POST /Startup/Useralways runs. It renames the first user and sets the password, returns 204 on a fresh install, and 403 when a previous attempt already set a password. Both are handled.How it was tested
rootwith no password,AuthenticateByName401.setupJellyfinagainst that exact broken state: succeeded, renamed the user toadmin, set the password, created Movies/TV/Music libraries, and completed the wizard.bun test: 342 pass. Typecheck clean.Checklist
bun testpassestsc --noEmitpasses