#205 get model for whole partition disk on linux - #216
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to correctly resolve the drive model on Linux when the benchmark path is on a whole-disk filesystem (where lsblk -no pkname can return an empty value).
Changes:
- Filtered out blank
lsblkoutput lines when resolving parent device names on Linux. - Added a Linux fallback in
Util.getDriveModelto query vendor/model directly from the resolved “partition” when no parent device name is returned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
jdm-core/src/main/java/jdiskmark/UtilOs.java |
Filters empty lsblk pkname lines while collecting parent device names. |
jdm-core/src/main/java/jdiskmark/Util.java |
Adds an empty-parent fallback for Linux drive-model detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve model for whole partition disk