[N-Dekker]

Replaced the use of platform specific sleep functions. Replaced a global inline function and a Sleep macro definition with a more modern lambda. Removed the milliseconds parameter, as it was always 5000 anyway.

[hjmjohnson]

Love the use of platform independant standards!

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Replaces platform-specific sleep code in itkMemoryProbesCollecterBaseTest.cxx with a local lambda using std::this_thread::sleep_for.

• The memory-probe test uses one optional five-second wait helper.

_{Reviews (2) · Last reviewed commit: "STYLE: Let MemoryProbesCollecterBaseTest..." · Reviewed by Greptile}

[N-Dekker]

Instead of the #if defined(TEST_WITH_SLEEP), we could also introduce a static constexpr local bool variable testWithSleep, and then do if constexpr (testWithSleep) here, to ensure that the syntax of the sleep_for call is always checked, unconditionally. Just if anyone likes that better... 😃

[N-Dekker]

It seems to me that in practice, the macro TEST_WITH_SLEEP is never defined! If I'm correct, that would mean that the proposed std::this_thread::sleep_for call would never be evaluated by the compiler. So then a syntax error or a missing #include would not be detected for the std::this_thread::sleep_for call. So maybe we should do something like if constexpr (testWithSleep) here, instead of #if defined(TEST_WITH_SLEEP)!

[hjmjohnson]

The ROI on the alternative approach is low. My personal opinion is that it would not be enough of an improvement to justify the extra work. I'm Fine if you choose to do it, but I would rather put the effort into other, more impactful PR reviews.

[N-Dekker]

Thanks but in general I think we should prefer if constexpr over #if, for the sake of maintainability. This just aims to be a good example. AI agents might learn from our examples 😉

Hereby force-pushed!