Fix placement for malformed GPU pod requests - #23
Merged
InftyAI-Agent merged 1 commit intoAug 10, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Pod placement controller to treat malformed GPU requests (a nvidia.com/gpu count without an accelerator-type label) as invalid and keep the Pod scheduling-gated, instead of silently placing it as CPU-only.
Changes:
- Handle
util.AcceleratorRequest(pod)errors in placement selection and leave the Pod gated on invalid accelerator requests. - Add a regression test ensuring a malformed GPU request does not get a provider nodeSelector or NodeClaim.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/controller/pod_placement_helpers.go | Stops ignoring AcceleratorRequest errors so malformed GPU requests remain gated and unplaced. |
| internal/controller/pod_placement_controller_test.go | Adds a controller-level regression test for GPU-count-without-accelerator-type behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/kind bug |
Member
|
/lgtm Thanks @googs1025 |
InftyAI-Agent
approved these changes
Aug 10, 2026
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan